Skip to content

Conversation

@google-labs-jules
Copy link

Implemented the final proposal for issue #251 by adding the analyzer_versions field to AppMetadata in clams/appmetadata/__init__.py. This new field allows multi-model apps to specify versions for multiple components. The singular analyzer_version field remains for single-model apps, and no validation is enforced on it (specifically, the hf- format proposal was discarded). Added comprehensive tests in tests/test_appmetadata.py to verify the new field and ensure existing functionality remains intact.


PR created automatically by Jules for task 17929783131841457298 started by @keighrim

This change adds `analyzer_versions` (plural) to `AppMetadata` to support
multi-model or multi-family apps. It is an optional map of analyzer IDs
to their versions. This aligns with the latest proposal in issue #251,
discarding the previous `hf-` prefix validation requirement for
`analyzer_version`.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@clams-bot clams-bot added this to infra Nov 22, 2025
@github-project-automation github-project-automation bot moved this to Todo in infra Nov 22, 2025
@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.37%. Comparing base (9dcad01) to head (2d3dcb9).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #268      +/-   ##
===========================================
+ Coverage    61.33%   61.37%   +0.04%     
===========================================
  Files            6        6              
  Lines          812      813       +1     
===========================================
+ Hits           498      499       +1     
  Misses         314      314              
Flag Coverage Δ
unittests 61.37% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@keighrim keighrim closed this Nov 27, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in infra Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants