-
Notifications
You must be signed in to change notification settings - Fork 0
added mmif, mmif source, mmif rewind commands migrated from clams-python SDK
#317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cleaned requirements.txt * renames serializer package * added vocab package
…sion of mmif-python)
* clams library does not explicitly imports mmif library * clams-python version is now specified in a separate file (not in setup.py) * mmif-python version is unspecified to enable using latest dev versions (with pip install --pre) * added missing files to sdist
…ded change_metadata method
…efault parameters are used
…t` classes from example app
- changed rewinder file name taking off mmif_. - changed _delete_last function name to be single underscored. - added CLI argument for number of views to rewind. - changed read_mmif from json.load() -> file.read()
* optimized MMIF file I/O * added rewinding by number of apps (opposed to number of views, not exposed in CLI)
… scheme is passed as a part of location string
…to 316-migrate-cli-fromclams-tommif
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #317 +/- ##
===========================================
- Coverage 92.59% 88.64% -3.95%
===========================================
Files 10 13 +3
Lines 1405 1621 +216
===========================================
+ Hits 1301 1437 +136
- Misses 104 184 +80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2e35843 to
2dff439
Compare
2dff439 to
11015e8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #316 .