Skip to content

Conversation

@keighrim
Copy link
Member

@keighrim keighrim commented Oct 6, 2025

fixes #311

@keighrim keighrim linked an issue Oct 6, 2025 that may be closed by this pull request
@clams-bot clams-bot added this to infra Oct 6, 2025
@github-project-automation github-project-automation bot moved this to Todo in infra Oct 6, 2025
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.98%. Comparing base (4c8a890) to head (7fa50e7).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
mmif/serialize/model.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #328      +/-   ##
===========================================
+ Coverage    87.95%   87.98%   +0.02%     
===========================================
  Files           13       13              
  Lines         1661     1673      +12     
===========================================
+ Hits          1461     1472      +11     
- Misses         200      201       +1     
Flag Coverage Δ
unittests 87.98% <96.29%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@keighrim keighrim merged commit ca56ca7 into develop Oct 29, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in infra Oct 29, 2025
@keighrim keighrim deleted the 311-checking-for-equality-on-mmif-instances-fails branch October 29, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Checking for equality on Mmif instances fails

2 participants