Annotation.id always in long form #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dated examples accordingly
marcverhagen
approved these changes
Jun 18, 2025
Contributor
marcverhagen
left a comment
marcverhagen
left a comment
There was a problem hiding this comment.
Looks good in general, I added a few comments all related to minor style issues.
One thing I would like to understand is why the string value of an id can be a short form, but that should not hold up merging this.
Member
Author
|
Made more changes to use long form at the assignment time as well, based on our recent in-person meetings. |
keighrim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(only gently) addresses #228 , namely the long form ID is not a requirement (yet), hence the old (1.0.x) MMIFs with references by short form ID should still be valid, but considered as deprecated fro now on. Invalidation of short form reference will be a part of v2.0.0.