migrating lapps types #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keighrim
force-pushed
the
202-lapps-types-migration
branch
from
6461702 to
e3e39f6
Compare
- got rid of "label"-like props and metadata from lapps types (available for inheriting from the `Annotation` type) - no longer `gender` prop for the generic `NE`
… annotations now have "text" prop
- vocab now support "shadowing" of props in subclasses - better handling of versioning of newly added types
keighrim
force-pushed
the
202-lapps-types-migration
branch
from
e3e39f6 to
e3698de
Compare
Member
Author
|
still waiting for the review to come back... |
Contributor
marcverhagen
left a comment
marcverhagen
left a comment
There was a problem hiding this comment.
Looks good in general. I did see a few little style errors and had one comment on the similarTo property for new types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #202 .
WIP tree is viewable at http://eldrad:32123/1.0.6b/vocabulary/ (or after locally built from this branch)
See linked issue for discussion.