Skip to content

Comments

[fix] additionalComposers 없을 때 빈 배열로 반환#84

Merged
k3vin7 merged 1 commit intomainfrom
fix/posts
Feb 18, 2026
Merged

[fix] additionalComposers 없을 때 빈 배열로 반환#84
k3vin7 merged 1 commit intomainfrom
fix/posts

Conversation

@k3vin7
Copy link
Contributor

@k3vin7 k3vin7 commented Feb 18, 2026

Summary

  • additionalComposers가 없는 경우 null 대신 빈 배열 []로 반환하도록 수정
  • 이전에 배포된 버전에서 additionalComposers 필드가 응답에 아예 포함되지 않는 문제 재배포로 해결

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@k3vin7 k3vin7 merged commit e810ab2 into main Feb 18, 2026
1 check passed
@gemini-code-assist
Copy link

Summary of Changes

Hello @k3vin7, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 PostResponseDto에서 additionalComposers 필드가 추가 작곡가가 없을 때 null 대신 빈 리스트를 반환하도록 수정하는 버그를 해결합니다. 이 변경사항은 API 응답의 일관성을 보장하고, 필드가 응답에서 완전히 누락되던 관련 문제를 해결합니다.

Highlights

  • additionalComposers 반환 로직 수정: additionalComposers 필드가 없는 경우 null 대신 빈 배열 []을 반환하도록 extractAdditionalComposers 메서드를 수정했습니다.
  • 이전 배포 문제 해결: additionalComposers 필드가 응답에 포함되지 않던 이전 배포 버전의 문제를 재배포를 통해 해결했습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/main/java/com/daramg/server/post/dto/PostResponseDto.java
    • additionalComposers가 없을 때 null 대신 빈 리스트를 반환하도록 extractAdditionalComposers 메서드를 수정했습니다.
    • 불필요한 isEmpty() 조건 검사를 제거했습니다.
Activity
  • 이 PR에 대한 활동은 아직 없습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이 Pull Request는 additionalComposers 필드가 없을 때 null 대신 빈 배열 []을 반환하도록 수정하여 API 응답의 일관성을 높이고 잠재적인 NullPointerException 발생 가능성을 줄였습니다. List.of()를 사용하여 불변의 빈 리스트를 반환하는 것은 좋은 구현 방식입니다.

if (post instanceof CurationPost curationPost
&& curationPost.getAdditionalComposers() != null
&& !curationPost.getAdditionalComposers().isEmpty()) {
&& curationPost.getAdditionalComposers() != null) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

curationPost.getAdditionalComposers().isEmpty() 조건이 제거되었습니다. 이제 additionalComposers 리스트가 null이 아니라면, 비어있는 리스트일지라도 스트림 처리를 통해 ComposerSummary 리스트로 변환됩니다. 이는 additionalComposers가 비어있을 때도 null 대신 빈 리스트를 반환하여 API 응답의 일관성을 유지하는 데 기여합니다.

.toList();
}
return null;
return List.of();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

additionalComposers가 존재하지 않거나 CurationPost 타입이 아닌 경우 null 대신 List.of()를 사용하여 불변의 빈 리스트를 반환하도록 변경되었습니다. 이는 클라이언트 코드에서 NullPointerException을 방지하고, 컬렉션 필드에 대해 항상 빈 컬렉션을 기대할 수 있도록 하여 API 사용성을 크게 향상시킵니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant