Conversation
Summary of ChangesHello @k3vin7, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 게시글 조회수 기능을 도입합니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully implements the view count feature for posts. It includes adding a view_count column to the Post entity, incrementing the view count when a post is viewed, and including the viewCount in the PostDetailResponse. The database migration script is also correctly provided. The changes are well-contained and address the stated objective.
| ); | ||
| } | ||
|
|
||
| @Transactional |
| @Transactional | ||
| public PostDetailResponse getPostById(Long postId, User user) { | ||
| Post post = entityUtils.getEntity(postId, Post.class); | ||
| post.incrementViewCount(); |
There was a problem hiding this comment.
Incrementing the view count directly within the getPostById method is a straightforward approach. However, consider if this operation should be asynchronous or debounced to prevent excessive database writes on rapid page refreshes, especially for high-traffic posts. For now, this is acceptable, but it's a potential area for optimization if performance becomes an issue.
| @Column(name = "view_count", nullable = false) | ||
| private int viewCount = 0; |
| public void incrementViewCount(){ | ||
| viewCount++; | ||
| } |
| PostStatus postStatus, | ||
| int likeCount, | ||
| int commentCount, | ||
| int viewCount, |
| post.getPostStatus(), | ||
| post.getLikeCount(), | ||
| post.getCommentCount(), | ||
| post.getViewCount(), |
| @@ -0,0 +1 @@ | |||
| ALTER TABLE posts ADD COLUMN view_count INT NOT NULL DEFAULT 0; | |||
Summary
Post엔티티에view_count컬럼 추가GET /posts/{postId}) 시 조회수 자동 증가PostDetailResponse에viewCount필드 추가DB 변경
V7__add_view_count_to_posts.sql:posts테이블에view_count INT NOT NULL DEFAULT 0컬럼 추가