Skip to content

Feature/change db provider#47

Open
DevFinesse wants to merge 14 commits intodevelopfrom
feature/change-db-provider
Open

Feature/change db provider#47
DevFinesse wants to merge 14 commits intodevelopfrom
feature/change-db-provider

Conversation

@DevFinesse
Copy link
Collaborator

No description provided.

[ProducesResponseType(StatusCodes.Status400BadRequest, Type = typeof(ResponseModel<BusinessModel>))]
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(ResponseModel<BusinessModel>))]
[HttpGet("{id:guid}/businesses")]
public async Task<IActionResult> GetUserBusinesses(Guid id)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this endpoint supposed to do?

[HttpPost]
public async Task<IActionResult> Create([FromBody] IndustryModel industry)
{
var id = await _manager.CreateIndustryAsync(industry.Name, industry.Description);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please adjust the INDUSTRY controller to follow the convention of the other controllers?

Task<BusinessModel?> GetByIdAsync(Guid id);
Task<BusinessModel?> GetBySlugAsync(string slug);
Task<BusinessModel[]> GetAllAsync();
Task<BusinessModel[]> GetUserBusinessesAsync(Guid UserId);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

[DataType(DataType.Time, ErrorMessage = "Invalid time format")]
public DateTimeOffset? EndTime { get; set; }

// [JsonIgnore]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove the commented code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants