Skip to content

Conversation

@claudioDcv
Copy link
Owner

No description provided.

claudioDcv and others added 3 commits November 29, 2017 10:18
# Conflicts:
#	dist/CompTabl3.js
#	dist/THead.js
#	dist/package.json

import Tabl3 from '../index';
import conector from '../conector/ajax';
import conector from '../connector/ajax';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

value: true
});

var _axios = require('axios');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'require' is not defined.

};

exports.default = ajax;
module.exports = exports['default']; No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'exports' is not defined.
'module' is not defined.

});
};

exports.default = ajax;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'exports' is not defined.

@@ -0,0 +1,24 @@
'use strict';

Object.defineProperty(exports, "__esModule", {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'exports' is not defined.

};

exports.default = ajax;
module.exports = exports['default']; No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'exports' is not defined.
'module' is not defined.

}
};

exports.default = ajax;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'exports' is not defined.

@@ -0,0 +1,28 @@
'use strict';

Object.defineProperty(exports, "__esModule", {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'exports' is not defined.

@@ -0,0 +1,28 @@
'use strict';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the function form of "use strict".


/* eslint-disable */
jest.mock('../conector/ajax');
jest.mock('../connector/ajax');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'jest' is not defined.

@codecov
Copy link

codecov bot commented Jan 17, 2018

Codecov Report

Merging #24 into master will decrease coverage by 5.02%.
The diff coverage is 58.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage    88.8%   83.78%   -5.03%     
==========================================
  Files          16       18       +2     
  Lines         393      444      +51     
  Branches      114      127      +13     
==========================================
+ Hits          349      372      +23     
- Misses         37       62      +25     
- Partials        7       10       +3
Impacted Files Coverage Δ
src/connector/ajax.js 0% <ø> (ø)
src/core/queryStringToJSON.js 100% <100%> (ø)
src/core/core.js 100% <100%> (ø) ⬆️
src/CompTabl3.jsx 76.57% <44.44%> (-8.16%) ⬇️
src/TFooter.jsx 84.61% <50%> (ø) ⬆️
src/TBody.jsx 91.66% <88.88%> (-8.34%) ⬇️
src/THead.jsx 86.66% <0%> (+2.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8765f44...91acde0. Read the comment docs.

Claudio Rojas Rodriguez added 2 commits January 17, 2018 19:27
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

jest.mock('../conector/ajax');
jest.mock('../connector/ajax');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'jest' is not defined.

}
pairs = queryString.split('&');
pairs.forEach((p) => {
let pair = p;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

queryString = queryString.split('?')[1];
}
pairs = queryString.split('&');
pairs.forEach((p) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

export default (qs) => {
let queryString = qs;
let pairs = '';
const result = {};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

@@ -0,0 +1,17 @@
export default (qs) => {
let queryString = qs;
let pairs = '';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

@@ -0,0 +1,17 @@
export default (qs) => {
let queryString = qs;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

@@ -0,0 +1,17 @@
export default (qs) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'export' is only available in ES6 (use 'esversion: 6').
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

export const removeParamFromQS = removeParam
export const extractParamFromQS = extractParam
export const extractParamFromQSInt = extractParamInt
export const querystringToJSON = queryStringToJSON

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'export' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.

import removeParam from './removeParamFromQS'
import extractParam from './extractParamFromQS'
import extractParamInt from './extractParamFromQSInt'
import queryStringToJSON from './queryStringToJSON';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

jest.mock('../conector/ajax');
jest.mock('../connector/ajax');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'jest' is not defined.

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

jest.mock('../conector/ajax');
jest.mock('../connector/ajax');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'jest' is not defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants