Ensure compilation with newest architectures#129
Open
sofiemartins wants to merge 2 commits intoclaudiopica:HiRep-CUDAfrom
Open
Ensure compilation with newest architectures#129sofiemartins wants to merge 2 commits intoclaudiopica:HiRep-CUDAfrom
sofiemartins wants to merge 2 commits intoclaudiopica:HiRep-CUDAfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## HiRep-CUDA #129 +/- ##
==============================================
- Coverage 49.00% 48.77% -0.23%
==============================================
Files 383 192 -191
Lines 58365 29781 -28584
Branches 10806 5876 -4930
==============================================
- Hits 28602 14526 -14076
+ Misses 26935 13792 -13143
+ Partials 2828 1463 -1365 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whether compilation without specification of the architecture compiles to the newest architecture depends on the system settings. In HiRep, the user may specify the architecture in the GPUFLAGS when building, but ideally, they don't have to. There was a specific case for Tursa, where the fat binary compiled without specification of the architecture compiles only for compute capability 5.2, which causes issues with cub reductions.
This was the origin of the issue in #126
The suggestion below enforces the usage of -arch=all, but only if the user did not specify the target architecture.
I tested this by checking the build commands by eye using nj -v.