Skip to content

Ensure compilation with newest architectures#129

Open
sofiemartins wants to merge 2 commits intoclaudiopica:HiRep-CUDAfrom
sofiemartins:arch_fix
Open

Ensure compilation with newest architectures#129
sofiemartins wants to merge 2 commits intoclaudiopica:HiRep-CUDAfrom
sofiemartins:arch_fix

Conversation

@sofiemartins
Copy link

Whether compilation without specification of the architecture compiles to the newest architecture depends on the system settings. In HiRep, the user may specify the architecture in the GPUFLAGS when building, but ideally, they don't have to. There was a specific case for Tursa, where the fat binary compiled without specification of the architecture compiles only for compute capability 5.2, which causes issues with cub reductions.

This was the origin of the issue in #126

The suggestion below enforces the usage of -arch=all, but only if the user did not specify the target architecture.
I tested this by checking the build commands by eye using nj -v.

@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.77%. Comparing base (458b7d0) to head (547b47e).

Additional details and impacted files
@@              Coverage Diff               @@
##           HiRep-CUDA     #129      +/-   ##
==============================================
- Coverage       49.00%   48.77%   -0.23%     
==============================================
  Files             383      192     -191     
  Lines           58365    29781   -28584     
  Branches        10806     5876    -4930     
==============================================
- Hits            28602    14526   -14076     
+ Misses          26935    13792   -13143     
+ Partials         2828     1463    -1365     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant