Skip to content

Made adendulu2.py less prone to throw unexpected errors#5

Merged
clause merged 1 commit intoclause:mainfrom
adendulu:main
Mar 2, 2026
Merged

Made adendulu2.py less prone to throw unexpected errors#5
clause merged 1 commit intoclause:mainfrom
adendulu:main

Conversation

@adendulu
Copy link
Copy Markdown
Contributor

@adendulu adendulu commented Mar 2, 2026

No description provided.

@codecov-commenter
Copy link
Copy Markdown

❌ 25 Tests Failed:

Tests completed Failed Passed Skipped
117 25 92 0
View the full list of 25 ❄️ flaky test(s)
tests.roman_converter.clause.test_to_roman::test_to_roman[roman_converter.adendulu3]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0.001s run time
impl = <module 'roman_converter.adendulu3' from '.../src/roman_converter/adendulu3.py'>

    def test_to_roman(impl: ModuleType):
>       assert impl.to_roman(4) == "IV"
E       AssertionError: assert 'IIII' == 'IV'
E         
E         - IV
E         + IIII

.../roman_converter/clause/test_to_roman.py:5: AssertionError
tests.roman_converter.clause.test_to_roman::test_to_roman[roman_converter.heowe_buggy]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0.001s run time
impl = <module 'roman_converter.heowe_buggy' from '.../src/roman_converter/heowe_buggy.py'>

    def test_to_roman(impl: ModuleType):
>       assert impl.to_roman(4) == "IV"
E       AssertionError: assert 'IIII' == 'IV'
E         
E         - IV
E         + IIII

.../roman_converter/clause/test_to_roman.py:5: AssertionError
tests.roman_converter.heowe.test_from_roman::test_basic_numerals[roman_converter.adendulu2]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.adendulu2' from '.../src/roman_converter/adendulu2.py'>

    def test_basic_numerals(impl: ModuleType):
>       assert impl.from_roman("I") == 1
E       AssertionError: assert 0 == 1
E        +  where 0 = <function from_roman at 0x7f9f803aef00>('I')
E        +    where <function from_roman at 0x7f9f803aef00> = <module 'roman_converter.adendulu2' from '.../src/roman_converter/adendulu2.py'>.from_roman

.../roman_converter/heowe/test_from_roman.py:6: AssertionError
tests.roman_converter.heowe.test_from_roman::test_compound_numerals[roman_converter.adendulu2]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.adendulu2' from '.../src/roman_converter/adendulu2.py'>

    def test_compound_numerals(impl: ModuleType):
>       assert impl.from_roman("XIV") == 14
E       AssertionError: assert 0 == 14
E        +  where 0 = <function from_roman at 0x7f9f803aef00>('XIV')
E        +    where <function from_roman at 0x7f9f803aef00> = <module 'roman_converter.adendulu2' from '.../src/roman_converter/adendulu2.py'>.from_roman

.../roman_converter/heowe/test_from_roman.py:37: AssertionError
tests.roman_converter.heowe.test_from_roman::test_compound_numerals[roman_converter.heowe_buggy]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.heowe_buggy' from '.../src/roman_converter/heowe_buggy.py'>

    def test_compound_numerals(impl: ModuleType):
>       assert impl.from_roman("XIV") == 14
E       AssertionError: assert 16 == 14
E        +  where 16 = <function from_roman at 0x7f9f803af480>('XIV')
E        +    where <function from_roman at 0x7f9f803af480> = <module 'roman_converter.heowe_buggy' from '.../src/roman_converter/heowe_buggy.py'>.from_roman

.../roman_converter/heowe/test_from_roman.py:37: AssertionError
tests.roman_converter.heowe.test_from_roman::test_compound_numerals[roman_converter.ross_a]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.ross_a' from '.../src/roman_converter/ross_a.py'>

    def test_compound_numerals(impl: ModuleType):
>       assert impl.from_roman("XIV") == 14
E       AssertionError: assert 10 == 14
E        +  where 10 = <function from_roman at 0x7f9f803afe20>('XIV')
E        +    where <function from_roman at 0x7f9f803afe20> = <module 'roman_converter.ross_a' from '.../src/roman_converter/ross_a.py'>.from_roman

.../roman_converter/heowe/test_from_roman.py:37: AssertionError
tests.roman_converter.heowe.test_from_roman::test_misc_values[roman_converter.adendulu2]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.adendulu2' from '.../src/roman_converter/adendulu2.py'>

    def test_misc_values(impl: ModuleType):
>       assert impl.from_roman("LVIII") == 58
E       AssertionError: assert 0 == 58
E        +  where 0 = <function from_roman at 0x7f9f803aef00>('LVIII')
E        +    where <function from_roman at 0x7f9f803aef00> = <module 'roman_converter.adendulu2' from '.../src/roman_converter/adendulu2.py'>.from_roman

.../roman_converter/heowe/test_from_roman.py:48: AssertionError
tests.roman_converter.heowe.test_from_roman::test_misc_values[roman_converter.heowe_buggy]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.heowe_buggy' from '.../src/roman_converter/heowe_buggy.py'>

    def test_misc_values(impl: ModuleType):
        assert impl.from_roman("LVIII") == 58
        assert impl.from_roman("DCXXI") == 621
        assert impl.from_roman("MDCCLXXVI") == 1776
>       assert impl.from_roman("MMCDXXI") == 2421
E       AssertionError: assert 2621 == 2421
E        +  where 2621 = <function from_roman at 0x7f9f803af480>('MMCDXXI')
E        +    where <function from_roman at 0x7f9f803af480> = <module 'roman_converter.heowe_buggy' from '.../src/roman_converter/heowe_buggy.py'>.from_roman

.../roman_converter/heowe/test_from_roman.py:51: AssertionError
tests.roman_converter.heowe.test_from_roman::test_misc_values[roman_converter.ross_a]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.ross_a' from '.../src/roman_converter/ross_a.py'>

    def test_misc_values(impl: ModuleType):
>       assert impl.from_roman("LVIII") == 58
E       AssertionError: assert 50 == 58
E        +  where 50 = <function from_roman at 0x7f9f803afe20>('LVIII')
E        +    where <function from_roman at 0x7f9f803afe20> = <module 'roman_converter.ross_a' from '.../src/roman_converter/ross_a.py'>.from_roman

.../roman_converter/heowe/test_from_roman.py:48: AssertionError
tests.roman_converter.heowe.test_from_roman::test_repetition[roman_converter.adendulu2]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.adendulu2' from '.../src/roman_converter/adendulu2.py'>

    def test_repetition(impl: ModuleType):
>       assert impl.from_roman("II") == 2
E       AssertionError: assert 0 == 2
E        +  where 0 = <function from_roman at 0x7f9f803aef00>('II')
E        +    where <function from_roman at 0x7f9f803aef00> = <module 'roman_converter.adendulu2' from '.../src/roman_converter/adendulu2.py'>.from_roman

.../roman_converter/heowe/test_from_roman.py:27: AssertionError
tests.roman_converter.heowe.test_from_roman::test_repetition[roman_converter.ross_a]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.ross_a' from '.../src/roman_converter/ross_a.py'>

    def test_repetition(impl: ModuleType):
        assert impl.from_roman("II") == 2
>       assert impl.from_roman("III") == 3
E       AssertionError: assert 2 == 3
E        +  where 2 = <function from_roman at 0x7f9f803afe20>('III')
E        +    where <function from_roman at 0x7f9f803afe20> = <module 'roman_converter.ross_a' from '.../src/roman_converter/ross_a.py'>.from_roman

.../roman_converter/heowe/test_from_roman.py:28: AssertionError
tests.roman_converter.heowe.test_from_roman::test_subtractive_notation[roman_converter.adendulu2]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.adendulu2' from '.../src/roman_converter/adendulu2.py'>

    def test_subtractive_notation(impl: ModuleType):
>       assert impl.from_roman("IV") == 4
E       AssertionError: assert 0 == 4
E        +  where 0 = <function from_roman at 0x7f9f803aef00>('IV')
E        +    where <function from_roman at 0x7f9f803aef00> = <module 'roman_converter.adendulu2' from '.../src/roman_converter/adendulu2.py'>.from_roman

.../roman_converter/heowe/test_from_roman.py:17: AssertionError
tests.roman_converter.heowe.test_from_roman::test_subtractive_notation[roman_converter.heowe_buggy]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.heowe_buggy' from '.../src/roman_converter/heowe_buggy.py'>

    def test_subtractive_notation(impl: ModuleType):
>       assert impl.from_roman("IV") == 4
E       AssertionError: assert 6 == 4
E        +  where 6 = <function from_roman at 0x7f9f803af480>('IV')
E        +    where <function from_roman at 0x7f9f803af480> = <module 'roman_converter.heowe_buggy' from '.../src/roman_converter/heowe_buggy.py'>.from_roman

.../roman_converter/heowe/test_from_roman.py:17: AssertionError
tests.roman_converter.heowe.test_from_roman::test_subtractive_notation[roman_converter.ross_a]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.ross_a' from '.../src/roman_converter/ross_a.py'>

    def test_subtractive_notation(impl: ModuleType):
>       assert impl.from_roman("IV") == 4
E       AssertionError: assert 6 == 4
E        +  where 6 = <function from_roman at 0x7f9f803afe20>('IV')
E        +    where <function from_roman at 0x7f9f803afe20> = <module 'roman_converter.ross_a' from '.../src/roman_converter/ross_a.py'>.from_roman

.../roman_converter/heowe/test_from_roman.py:17: AssertionError
tests.roman_converter.heowe.test_to_roman::test_compound_numerals[roman_converter.adendulu3]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.adendulu3' from '.../src/roman_converter/adendulu3.py'>

    def test_compound_numerals(impl: ModuleType):
>       assert impl.to_roman(14) == "XIV"
E       AssertionError: assert 'XIIII' == 'XIV'
E         
E         - XIV
E         + XIIII

.../roman_converter/heowe/test_to_roman.py:37: AssertionError
tests.roman_converter.heowe.test_to_roman::test_compound_numerals[roman_converter.heowe_buggy]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.heowe_buggy' from '.../src/roman_converter/heowe_buggy.py'>

    def test_compound_numerals(impl: ModuleType):
>       assert impl.to_roman(14) == "XIV"
E       AssertionError: assert 'XIIII' == 'XIV'
E         
E         - XIV
E         + XIIII

.../roman_converter/heowe/test_to_roman.py:37: AssertionError
tests.roman_converter.heowe.test_to_roman::test_misc_values[roman_converter.adendulu3]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0.001s run time
impl = <module 'roman_converter.adendulu3' from '.../src/roman_converter/adendulu3.py'>

    def test_misc_values(impl: ModuleType):
        assert impl.to_roman(58) == "LVIII"
        assert impl.to_roman(621) == "DCXXI"
        assert impl.to_roman(1776) == "MDCCLXXVI"
>       assert impl.to_roman(2421) == "MMCDXXI"
E       AssertionError: assert 'MMCCCCXXI' == 'MMCDXXI'
E         
E         - MMCDXXI
E         ?    ^
E         + MMCCCCXXI
E         ?    ^^^

.../roman_converter/heowe/test_to_roman.py:51: AssertionError
tests.roman_converter.heowe.test_to_roman::test_misc_values[roman_converter.heowe_buggy]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0.001s run time
impl = <module 'roman_converter.heowe_buggy' from '.../src/roman_converter/heowe_buggy.py'>

    def test_misc_values(impl: ModuleType):
        assert impl.to_roman(58) == "LVIII"
        assert impl.to_roman(621) == "DCXXI"
        assert impl.to_roman(1776) == "MDCCLXXVI"
>       assert impl.to_roman(2421) == "MMCDXXI"
E       AssertionError: assert 'MMCCCCXXI' == 'MMCDXXI'
E         
E         - MMCDXXI
E         ?    ^
E         + MMCCCCXXI
E         ?    ^^^

.../roman_converter/heowe/test_to_roman.py:51: AssertionError
tests.roman_converter.heowe.test_to_roman::test_subtractive_notation[roman_converter.adendulu3]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0.001s run time
impl = <module 'roman_converter.adendulu3' from '.../src/roman_converter/adendulu3.py'>

    def test_subtractive_notation(impl: ModuleType):
>       assert impl.to_roman(4) == "IV"
E       AssertionError: assert 'IIII' == 'IV'
E         
E         - IV
E         + IIII

.../roman_converter/heowe/test_to_roman.py:17: AssertionError
tests.roman_converter.heowe.test_to_roman::test_subtractive_notation[roman_converter.heowe_buggy]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.heowe_buggy' from '.../src/roman_converter/heowe_buggy.py'>

    def test_subtractive_notation(impl: ModuleType):
>       assert impl.to_roman(4) == "IV"
E       AssertionError: assert 'IIII' == 'IV'
E         
E         - IV
E         + IIII

.../roman_converter/heowe/test_to_roman.py:17: AssertionError
tests.roman_converter.ross.test_from_roman::test_from_roman[roman_converter.adendulu2]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.adendulu2' from '.../src/roman_converter/adendulu2.py'>

    def test_from_roman(impl: ModuleType):
        # Base Case Coverage - Variations
>       assert impl.from_roman("MCDXLVII") == 1447 # uses all letters at least once
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       AssertionError: assert 0 == 1447
E        +  where 0 = <function from_roman at 0x7f9f803aef00>('MCDXLVII')
E        +    where <function from_roman at 0x7f9f803aef00> = <module 'roman_converter.adendulu2' from '.../src/roman_converter/adendulu2.py'>.from_roman

.../roman_converter/ross/test_from_roman.py:6: AssertionError
tests.roman_converter.ross.test_from_roman::test_from_roman[roman_converter.heowe_buggy]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.heowe_buggy' from '.../src/roman_converter/heowe_buggy.py'>

    def test_from_roman(impl: ModuleType):
        # Base Case Coverage - Variations
>       assert impl.from_roman("MCDXLVII") == 1447 # uses all letters at least once
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       AssertionError: assert 1667 == 1447
E        +  where 1667 = <function from_roman at 0x7f9f803af480>('MCDXLVII')
E        +    where <function from_roman at 0x7f9f803af480> = <module 'roman_converter.heowe_buggy' from '.../src/roman_converter/heowe_buggy.py'>.from_roman

.../roman_converter/ross/test_from_roman.py:6: AssertionError
tests.roman_converter.ross.test_from_roman::test_from_roman[roman_converter.ross_a]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.ross_a' from '.../src/roman_converter/ross_a.py'>

    def test_from_roman(impl: ModuleType):
        # Base Case Coverage - Variations
>       assert impl.from_roman("MCDXLVII") == 1447 # uses all letters at least once
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       AssertionError: assert 1000 == 1447
E        +  where 1000 = <function from_roman at 0x7f9f803afe20>('MCDXLVII')
E        +    where <function from_roman at 0x7f9f803afe20> = <module 'roman_converter.ross_a' from '.../src/roman_converter/ross_a.py'>.from_roman

.../roman_converter/ross/test_from_roman.py:6: AssertionError
tests.roman_converter.ross.test_to_roman::test_to_roman[roman_converter.adendulu3]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.adendulu3' from '.../src/roman_converter/adendulu3.py'>

    def test_to_roman(impl: ModuleType):
        # Base Case Coverage - Variations
>       assert impl.to_roman(1447) == "MCDXLVII" # uses all letters at least once
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       AssertionError: assert 'MCCCCXXXXVII' == 'MCDXLVII'
E         
E         - MCDXLVII
E         + MCCCCXXXXVII

.../roman_converter/ross/test_to_roman.py:6: AssertionError
tests.roman_converter.ross.test_to_roman::test_to_roman[roman_converter.heowe_buggy]

Flake rate in main: 100.00% (Passed 0 times, Failed 2 times)

Stack Traces | 0s run time
impl = <module 'roman_converter.heowe_buggy' from '.../src/roman_converter/heowe_buggy.py'>

    def test_to_roman(impl: ModuleType):
        # Base Case Coverage - Variations
>       assert impl.to_roman(1447) == "MCDXLVII" # uses all letters at least once
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       AssertionError: assert 'MCCCCXXXXVII' == 'MCDXLVII'
E         
E         - MCDXLVII
E         + MCCCCXXXXVII

.../roman_converter/ross/test_to_roman.py:6: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@clause clause merged commit 314e76d into clause:main Mar 2, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants