Skip to content

Add error to get method when no key is passed #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pedro-rosario wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add error to get method when no key is passed #24

pedro-rosario wants to merge 3 commits into from

Conversation

@pedro-rosario
Copy link

@pedro-rosario pedro-rosario commented Nov 22, 2018

Closes #23

manuelurenah
manuelurenah approved these changes Nov 22, 2018
View reviewed changes
Copy link
Contributor

@manuelurenah manuelurenah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good man 🍻

jonwinton
jonwinton approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@jonwinton jonwinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'd like a look from @zonika and @yuliyv

@TTaitFoster TTaitFoster added the bug Something isn't working label Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jonwinton jonwinton jonwinton approved these changes

@manuelurenah manuelurenah manuelurenah approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pedro-rosario @jonwinton @manuelurenah @TTaitFoster