Merged
Conversation
- tsconfig.jsonをtsconfig.base.jsonから継承するよう変更 - 未使用のインポートを削除（Column, DataSource, FilterOperator） - ESMモジュールとして正しくビルドされるよう修正 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes the TypeScript configuration for the db-adapter package to align with the repository's standard pattern and removes unused type imports.
Changes:
- Updated tsconfig.json to extend from tsconfig.base.json instead of tsconfig.json (consistent with other packages)
- Removed unused Column import from types/index.ts
- Removed unused DataSource and FilterOperator imports from executor/types.ts with explanatory comment
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/db-adapter/tsconfig.json | Fixed inheritance to use tsconfig.base.json, aligning with other packages (protocol, react, ai-provider) |
| packages/db-adapter/src/types/index.ts | Removed unused Column type import |
| packages/db-adapter/src/executor/types.ts | Removed unused DataSource and FilterOperator imports (these types are imported where actually used in PrismaExecutor.ts and utils.ts) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code