Adding popover component page #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clearfeld
requested changes
Aug 9, 2024
Comment on lines
130
to
131
| border: "0.0625rem solid var(--sidebar-color-bg-hover)", | ||
| backgroundColor: "var(--color-bg-compliment)", |
Owner
There was a problem hiding this comment.
Examples shouldn't have / use our internal site specific css variables. They should be general enough that they can be copied into any project without additional setup post copy.
|
|
||
| { | ||
| title: "Popover", | ||
| description: "Popover Button. Click to display card's content to either the left, right, top or bottom of the button.", |
Owner
There was a problem hiding this comment.
Change the description, to something like
Displays rich content in a portal, that is triggered by a customizable trigger component
The popover isn't button specific.
Collaborator
Author
|
Modified, please check again. |
Collaborator
Author
|
Fixed some conflicts, please check @clearfeld |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.