-
Notifications
You must be signed in to change notification settings - Fork 3
build(deps): bump the cargo group across 7 directories with 1 update #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
build(deps): bump the cargo group across 7 directories with 1 update #172
Conversation
Bumps the cargo group with 1 update in the /experiments/bevy_blob directory: [bytes](https://github.com/tokio-rs/bytes). Bumps the cargo group with 1 update in the /experiments/bevy_ophanim directory: [bytes](https://github.com/tokio-rs/bytes). Bumps the cargo group with 1 update in the /experiments/bevy_shuriken directory: [bytes](https://github.com/tokio-rs/bytes). Bumps the cargo group with 1 update in the /experiments/cube_compound directory: [bytes](https://github.com/tokio-rs/bytes). Bumps the cargo group with 1 update in the /experiments/merkaba directory: [bytes](https://github.com/tokio-rs/bytes). Bumps the cargo group with 1 update in the /experiments/shuriken2 directory: [bytes](https://github.com/tokio-rs/bytes). Bumps the cargo group with 1 update in the /experiments/spiky_ball directory: [bytes](https://github.com/tokio-rs/bytes). Updates `bytes` from 1.11.0 to 1.11.1 - [Release notes](https://github.com/tokio-rs/bytes/releases) - [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md) - [Commits](tokio-rs/bytes@v1.11.0...v1.11.1) Updates `bytes` from 1.11.0 to 1.11.1 - [Release notes](https://github.com/tokio-rs/bytes/releases) - [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md) - [Commits](tokio-rs/bytes@v1.11.0...v1.11.1) Updates `bytes` from 1.11.0 to 1.11.1 - [Release notes](https://github.com/tokio-rs/bytes/releases) - [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md) - [Commits](tokio-rs/bytes@v1.11.0...v1.11.1) Updates `bytes` from 1.11.0 to 1.11.1 - [Release notes](https://github.com/tokio-rs/bytes/releases) - [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md) - [Commits](tokio-rs/bytes@v1.11.0...v1.11.1) Updates `bytes` from 1.11.0 to 1.11.1 - [Release notes](https://github.com/tokio-rs/bytes/releases) - [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md) - [Commits](tokio-rs/bytes@v1.11.0...v1.11.1) Updates `bytes` from 1.11.0 to 1.11.1 - [Release notes](https://github.com/tokio-rs/bytes/releases) - [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md) - [Commits](tokio-rs/bytes@v1.11.0...v1.11.1) Updates `bytes` from 1.11.0 to 1.11.1 - [Release notes](https://github.com/tokio-rs/bytes/releases) - [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md) - [Commits](tokio-rs/bytes@v1.11.0...v1.11.1) --- updated-dependencies: - dependency-name: bytes dependency-version: 1.11.1 dependency-type: indirect dependency-group: cargo - dependency-name: bytes dependency-version: 1.11.1 dependency-type: indirect dependency-group: cargo - dependency-name: bytes dependency-version: 1.11.1 dependency-type: indirect dependency-group: cargo - dependency-name: bytes dependency-version: 1.11.1 dependency-type: indirect dependency-group: cargo - dependency-name: bytes dependency-version: 1.11.1 dependency-type: indirect dependency-group: cargo - dependency-name: bytes dependency-version: 1.11.1 dependency-type: indirect dependency-group: cargo - dependency-name: bytes dependency-version: 1.11.1 dependency-type: indirect dependency-group: cargo ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 00800f3 in 33 seconds. Click for details.
- Reviewed
112lines of code in7files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_5sFpy2izR7Vzb2th
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Codacy's Analysis Summary0 new issue (≤ 0 issue) Review Pull Request in Codacy →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto Pull Request Review from LlamaPReview
Review Status: Automated Review Skipped
Dear contributor,
Thank you for your Pull Request. LlamaPReview has analyzed your changes and determined that this PR does not require an automated code review.
Analysis Result:
All 7 files are skipped files
Technical Context:
All files in this PR were marked as skipped, which typically includes:
- Generated files
- Build artifacts
- Pre-filtered content
- Files marked with [SKIPPED] tag
We're continuously improving our PR analysis capabilities. Have thoughts on when and how LlamaPReview should perform automated reviews? Share your insights in our GitHub Discussions.
Best regards,
LlamaPReview Team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed cf7dc4f in 26 seconds. Click for details.
- Reviewed
479lines of code in35files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_4mKbM39voiwLNygo
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
| fn main() { | ||
| App::new() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no explicit error handling for plugin or system initialization failures in the main function. If a plugin fails to load or a system panics during startup, the application may terminate without clear diagnostics. Consider adding error logging or handling mechanisms to improve robustness and debuggability.
| for i in 0..16 { | ||
| let theta = 2.0 * std::f32::consts::PI * i as f32 / golden_ratio; | ||
| let theta = 2.0 * std::f32::constants::PI * i as f32 / golden_ratio; | ||
| let phi = ((2 * i + 1) as f32 / 16.0 - 1.0).acos(); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially incorrect Fibonacci sphere distribution:
The calculation for theta and phi does not match the standard Fibonacci sphere algorithm, which may result in uneven spike placement. The typical approach is:
let N = 16.0;
let phi = (1.0 - 2.0 * (i as f32 + 0.5) / N).acos();
let theta = 2.39996323 * i as f32; // golden angle in radiansConsider updating the calculation to ensure even distribution of spikes around the sphere.
| fn paddle_handle_at(position: Vec3) -> RespawnHandle { | ||
| RespawnHandle { | ||
| spawn: SpawnTransform::new(position, Quat::from_rotation_x(-std::f32::consts::PI / 2.0)), | ||
| spawn: SpawnTransform::new(position, Quat::from_rotation_x(-std::f32::constants::PI / 2.0)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect constant usage
std::f32::constants::PI does not exist in Rust's standard library. The correct constant is std::f32::consts::PI.
Recommended fix:
Replace:
Quat::from_rotation_x(-std::f32::constants::PI / 2.0)with:
Quat::from_rotation_x(-std::f32::consts::PI / 2.0)This will resolve the compilation error.
| fn paddle_handle_at(position: Vec3) -> RespawnHandle { | ||
| RespawnHandle { | ||
| spawn: SpawnTransform::new(position, Quat::from_rotation_x(-std::f32::consts::PI / 2.0)), | ||
| spawn: SpawnTransform::new(position, Quat::from_rotation_x(-std::f32::constants::PI / 2.0)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paddle spawn transform uses a hardcoded rotation of Quat::from_rotation_x(-std::f32::consts::PI / 2.0). If the paddle's orientation requirements change, this function will require manual updates, which could lead to maintenance issues. Consider parameterizing the rotation or referencing a constant that reflects the canonical paddle orientation to improve maintainability.
Bumps the cargo group with 1 update in the /experiments/bevy_blob directory: bytes.
Bumps the cargo group with 1 update in the /experiments/bevy_ophanim directory: bytes.
Bumps the cargo group with 1 update in the /experiments/bevy_shuriken directory: bytes.
Bumps the cargo group with 1 update in the /experiments/cube_compound directory: bytes.
Bumps the cargo group with 1 update in the /experiments/merkaba directory: bytes.
Bumps the cargo group with 1 update in the /experiments/shuriken2 directory: bytes.
Bumps the cargo group with 1 update in the /experiments/spiky_ball directory: bytes.
Updates
bytesfrom 1.11.0 to 1.11.1Release notes
Sourced from bytes's releases.
Changelog
Sourced from bytes's changelog.
Commits
417dccdRelease bytes v1.11.1 (#820)d0293b0Merge commit from forkUpdates
bytesfrom 1.11.0 to 1.11.1Release notes
Sourced from bytes's releases.
Changelog
Sourced from bytes's changelog.
Commits
417dccdRelease bytes v1.11.1 (#820)d0293b0Merge commit from forkUpdates
bytesfrom 1.11.0 to 1.11.1Release notes
Sourced from bytes's releases.
Changelog
Sourced from bytes's changelog.
Commits
417dccdRelease bytes v1.11.1 (#820)d0293b0Merge commit from forkUpdates
bytesfrom 1.11.0 to 1.11.1Release notes
Sourced from bytes's releases.
Changelog
Sourced from bytes's changelog.
Commits
417dccdRelease bytes v1.11.1 (#820)d0293b0Merge commit from forkUpdates
bytesfrom 1.11.0 to 1.11.1Release notes
Sourced from bytes's releases.
Changelog
Sourced from bytes's changelog.
Commits
417dccdRelease bytes v1.11.1 (#820)d0293b0Merge commit from forkUpdates
bytesfrom 1.11.0 to 1.11.1Release notes
Sourced from bytes's releases.
Changelog
Sourced from bytes's changelog.
Commits
417dccdRelease bytes v1.11.1 (#820)d0293b0Merge commit from forkUpdates
bytesfrom 1.11.0 to 1.11.1Release notes
Sourced from bytes's releases.
Changelog
Sourced from bytes's changelog.
Commits
417dccdRelease bytes v1.11.1 (#820)d0293b0Merge commit from forkDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.
Important
Updates
bytesto 1.11.1 across multiple directories and renamesstd::f32::consts::PItostd::f32::constants::PIin several files.bytesfrom 1.11.0 to 1.11.1 inCargo.lockfiles acrossbevy_blob,bevy_ophanim,bevy_shuriken,cube_compound,merkaba,shuriken2, andspiky_balldirectories.BytesMut::reserve.std::f32::consts::PItostd::f32::constants::PIinbevy_blob/src/main.rs,bevy_ophanim/src/main.rs,bevy_shuriken/src/main.rs,cube_compound/src/main.rs,merkaba/src/main.rs,shuriken2/src/main.rs,spiky_ball/src/main.rs,level_loader.rs,respawn.rs,paddle_shrink.rs, andrespawn_timer.rs.This description was created by
for cf7dc4f. You can customize this summary. It will automatically update as commits are pushed.