lua: add movie.getMarker(), movie.setMarker(), movie.insertFrame() and movie.insertFrames()#668
Open
Perdu wants to merge 4 commits intoclementgallet:masterfrom
Open
lua: add movie.getMarker(), movie.setMarker(), movie.insertFrame() and movie.insertFrames()#668Perdu wants to merge 4 commits intoclementgallet:masterfrom
Perdu wants to merge 4 commits intoclementgallet:masterfrom
Conversation
This paves the road towards more movie control in lua
Perdu
changed the title
Owner
|
Thanks for the PR! I'm not super fan of adding the movie to the context. I would like to keep the context struct as short as possible, for code clarity. You could maybe look at what I did for passing the inputs to lua (see |
Contributor
Author
|
OK, done and tested |
Perdu
changed the title
Contributor
Author
|
Added a commit to add movie.insertFrame() and movie.insertFrames() (not making a separate PR because this is built on top of this as this also requires access to |
Contributor
Author
|
CI error is unrelated ("Build execution time has reached the maximum allowed time for your plan (60 minutes).") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This paves the road towards more movie control in lua
Note: I have to add MovieFile to context for this. I'm quite unsure whether this should be updated after SaveState.cpp:35 (in any case, this does not impact markers)