Made some changes to improve user experience. Read the comment for more.#10
Open
Nirmal-Palanichamy wants to merge 3 commits intoclementmihailescu:masterfrom
Open
Made some changes to improve user experience. Read the comment for more.#10Nirmal-Palanichamy wants to merge 3 commits intoclementmihailescu:masterfrom
Nirmal-Palanichamy wants to merge 3 commits intoclementmihailescu:masterfrom
Conversation
Previously, right click on the board would open up the context menu. This is unnecessary and so it is disabled.
Previously, both left and right mouse buttons could add as well as delete walls. Now, left mouse button will only be able to add walls and right mouse button will only be able to delete walls.
Previously, when creating walls, it seemed to be kind of buggy. Also, when the user drags out of the page, on bringing the cursor back, it would continue to create walls. Now, mouseup function has been added to body to reduce buggy feeling and also, mouseleave function has been added to stop creating walls after leaving the page and returning back. NOTE: This was only done for normal elements and NOT special elements.
Author
|
You can try it out here: https://nirmal-palanichamy.github.io/Pathfinding-Visualizer/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all... Big fan Clement! :)
I love this project. But, when I was checking out the project, it felt a little buggy while creating walls. So I've added these 3 features to make it better:
Let me know if I need to change anything before this can be merged. Cheers :)