-
Notifications
You must be signed in to change notification settings - Fork 817
Embed tooltips in to docs #2399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
I'm thinking we should the change the syntax from to and then the logic will understand that the ! means to look in the what are your thoughts on this syntax? also, this is something I can try work on! or maybe we can pair :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there are links in a tooltip, does the link checker accommodate those?
I'll have to check, I'll add a test, I hope its yes, my hunch is no. |
Was blocked by https://github.com/clerk/clerk/pull/1359
🔎 Previews:
What does this solve?
Extracts
pulls the content from the
_tooltips/ABC.mdx
file,and transforms it in to
This is because mdx is weird and children props get treated differently to standard props. So to ensure that both the title text and the tooltip content are treated as mdx not just a string, we need to embed them in to there own children inside components.
Checklist