-
Notifications
You must be signed in to change notification settings - Fork 837
Ensure all hooks are using typedocs + have code examples for each supported SDK #2649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SarahSoutoul
wants to merge
26
commits into
main
Choose a base branch
from
ss/DOCS-10983
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7d0c880
to
8225f3c
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔎 Previews:
What does this solve?
Fixes https://linear.app/clerk/issue/DOCS-10983/ensure-all-hooks-are-using-typedocs-have-code-examples-for-each.
This PR is part of a broader project aimed at adding more code examples to our hooks documentation. During project discussions, we agreed that the current structure of our hooks docs needed to be revisited. Currently, most of the hook pages are fully rendered through Typedoc, including code examples. However, adding additional examples through Typedoc would have required significant restructuring of the JavaScript repo.
To address this, we decided to:
javascript
for this: hhttps://github.com/docs(repo): Generate all params and return types (hooks work) javascript#6901.Additionally, not all hooks currently use Typedoc. This PR also ensures that all hooks are properly configured to use Typedoc for their returns and parameters.
This PR includes:
This PR will be the second in a sequence. First, we need to merge the
javascript
PR, which:What changed?
This PR adds all the code examples for the supported SDKs for each hook + uses the newly rendered Typedoc returns/ parameters, placing them after the examples for the most part.
Testing
useAuth
- already using typedoc, but examples need to be moved outuseClerk
- already using typedoc, but examples need to be moved outuseUser
- already using typedoc, but examples need to be moved outuseSession
- already using typedoc, but examples need to be moved outuseSessionList
- already using typedoc, but examples need to be moved outuseSignIn
- already using typedoc, but examples need to be moved outuseSignUp
- - already using typedoc, but examples need to be moved outuseCheckout
- need to be using typedocusePaymentAttempts
- need to be using typedocusePaymentElement
- need to be using typedocusePaymentMethods
- need to be using typedocusePlans
- need to be using typedocuseStatements
- need to be using typedocuseSubscription
- need to be using typedocuseReverification
- need to be using typedoc (examples already done)Checklist