-
Notifications
You must be signed in to change notification settings - Fork 5
Added German translation. Improved translatability overall. New feature: Max dose per # of days #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I reworked those fragmented strings into strings with %1$s placeholders so that it's easier to translate into other languages. I also added the most important toast messages to strings.xml to make them translatable and made the deletion-warning-strings more explicit instead of just phrasing them as "are you sure you want to delete this element?". I also added some colons to some of the English strings (e.g. "taken: "). This should help keep the label clean in all languages. The most important word comes first, followed by a colon and then the time span string. One problem remains for the time being. The way the user selects how often a med can be taken (e.g. max 1 every 6 hours) can be hard to translate. It works well in German but I assume that other languages won't be compatible here. Nothing major but might need adjustment in the future. Best |
|
I just saw that I missed some of the notifications title and content. Not broken, but incomplete as of now |
|
Fixed a bunch of lint warnings in 00c1d22. I was careful to not change any logic here. I also updated all dependencies and tested functionality. Everything seems to work as expected. Finally I improved some German translations and also reworked the notification strings so that they are properly translatable. I think it would be very cool to have this project on something like weblate or some other translation platform so that users can more easily contribute translations for other languages. |
|
Oh, I also downgraded com.android.tools.build:gradle:8.13.1 to 8:12.3 and disabled the configuration cache because the app wouldn't compile otherwise. I'm not sure if this is just a problem on my end. Please adjust if necessary. |
Love the app. Great job! :)
I translated all strings to German. I built the whole thing and tested it. Looks good imo. I'm a native German speaker btw.
Not sure about the fastlane/metadata folder structure though. Adjust if necessary
Best