Open
Conversation
auvipy
requested changes
Sep 8, 2024
| @@ -1,7 +0,0 @@ | |||
| #!/usr/bin/env python3 | |||
Author
There was a problem hiding this comment.
Would you elaborate on why you would want that? setup.py is deprecated, and you should instead use pip, python -m build, etc. commands instead that are PEP517 compatible.
As a Fedora packager, the only issue that I've encountered is in packaging for EPEL9 due to ancient setuptools that do not support PEP621, but that is easily resolved by moving to hatchling and this can even be done downstream by the packager only if upstream does not wish to move to hatchling
| @@ -1,47 +0,0 @@ | |||
| [metadata] | |||
auvipy
requested changes
May 19, 2025
Collaborator
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
I'm going to block this PR for a while and revisit and probably implement by myself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mostly to migrate to PEP621 but in the process needed to add a few other improvements to fully migrate:
I, B, Q, COM, PL, and recommended for upgradesUP, PTHRelated, how about using
setuptools_scm?Makefile? The remaining usage of it looks outdatednox? This seems to be the recommended upgrade fromtox