feat(featurebase): switch to JWT auth and restore feedback widget#80
Draft
johnwschoi wants to merge 1 commit intomainfrom
Draft
feat(featurebase): switch to JWT auth and restore feedback widget#80johnwschoi wants to merge 1 commit intomainfrom
johnwschoi wants to merge 1 commit intomainfrom
Conversation
4 tasks
a7a4a90 to
08c9241
Compare
- Add dedicated getFeaturebaseToken tRPC query through full runtime stack - Rewrite hook: remove mount-time identify, fetch fresh JWT on each open - Restore Share Feedback button and hook wiring removed by f89668d - Fail-closed with toast errors when JWT auth fails - Fix race condition: widget only opens after successful identify - Remove data-featurebase-feedback to prevent SDK auto-open bypass - Gate feedback button on Cline OAuth session - Comprehensive tests for runtime, hook, and FeedbackCard Ref: ENG-1673
08c9241 to
d706d96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getFeaturebaseTokentRPC query through the runtime stack (api-contract→ SDK boundary → provider service → runtime-api → app-router → browser query helper)fetch me/getClineAccountProfile, because the JWT is short-lived and Featurebase-specific and should be fetched fresh on widget open rather than carried on a generic profile responseuseFeaturebaseFeedbackWidgetso it:identify({ email, name, userId })Featurebase("identify", { featurebaseJwt })Share Feedbackbutton and app hook wiring removed byf89668dShare Feedbackon an authenticated Cline session and shows a sign-in message when unavailableTest plan
featurebaseJwtis passed toidentifyDependencies
FEATUREBASE_JWT_SECRETRef: ENG-1673