Upgrade rails to 7.2.x version; clean up unsupported rails and ruby version #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendy-clio
commented
Nov 1, 2024
| ActiveRecord::MigrationContext.new(migrations_path, ActiveRecord::SchemaMigration).migrate | ||
| end | ||
|
|
||
| if active_record_version >= Gem::Version.new("7.0") |
Contributor
Author
There was a problem hiding this comment.
Rails has been back and forth about how to use the MigrationContext https://stackoverflow.com/questions/60974746/what-do-i-pass-to-schema-migration-in-activerecordmigrationcontextnew
wendy-clio
force-pushed
the
upgrade_rails_to_7_2
branch
3 times, most recently
from
8ffff44 to
29af2fe
Compare
wendy-clio
commented
Nov 1, 2024
| gemspec path: ".." | ||
|
|
||
| gem "activerecord", github: "rails/rails", branch: "6-1-stable" | ||
| gem "sqlite3", "~> 1.4" |
Contributor
Author
There was a problem hiding this comment.
The newer version (2.x.x) is released but the older rails versions are still pin to use a lower version (~> 1.4).
Reference PR
Only the latest version (7.2.x) is able to use a higher version.
wendy-clio
commented
Nov 1, 2024
| gemspec path: ".." | ||
|
|
||
| gem "activerecord", github: "rails/rails", branch: "7-0-stable" | ||
| gem "sqlite3", "~> 1.4" |
RafeSl
reviewed
Nov 4, 2024
wendy-clio
force-pushed
the
upgrade_rails_to_7_2
branch
from
29af2fe to
6253f67
Compare
RafeSl
approved these changes
Jan 13, 2025
RafeSl
left a comment
RafeSl
left a comment
There was a problem hiding this comment.
Not seeing any issuse and the config change I suggested has been made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve the requested issue.
Also, clean up unsupported rails version (< 6.1) and ruby version(< 3.0)