Macos passthrough implementation#182
Macos passthrough implementation#182akitaSummer wants to merge 9 commits intocloud-hypervisor:masterfrom
Conversation
akitaSummer
requested review from
bergwolf,
eryugey,
imeoer,
jiangliu and
liubogithub
as code owners
akitaSummer
force-pushed
the
macos_passthrough
branch
from
ce18bc9 to
2b3daf5
Compare
|
@akitaSummer Some CI tests failed, PTAL. :) |
akitaSummer
force-pushed
the
macos_passthrough
branch
from
0aa8a76 to
f3865cd
Compare
Signed-off-by: akitaSummer <644171127@qq.com>
Signed-off-by: akitaSummer <644171127@qq.com>
Signed-off-by: akitaSummer <644171127@qq.com>
Signed-off-by: akitaSummer <644171127@qq.com>
akitaSummer
force-pushed
the
macos_passthrough
branch
from
f3865cd to
28f93e3
Compare
|
@imeoer Please help me try CI again |
akitaSummer
force-pushed
the
macos_passthrough
branch
2 times, most recently
from
92e4739 to
fe23c44
Compare
WeiZhang555
left a comment
WeiZhang555
left a comment
There was a problem hiding this comment.
There're lots of #[cfg(target_os = "macos")] here and there, spreading all across several files, is that possible to split them to different files?
Similar to
src/abi/
|- fuse_abi_linux.rs
|- fuse_abi_macos.rs
There should be a balance between code readability and code redundancy.
akitaSummer
force-pushed
the
macos_passthrough
branch
2 times, most recently
from
e1ceb1d to
2318011
Compare
Signed-off-by: akitaSummer <644171127@qq.com>
akitaSummer
force-pushed
the
macos_passthrough
branch
from
2318011 to
fbd70b9
Compare
WeiZhang555
left a comment
WeiZhang555
left a comment
There was a problem hiding this comment.
Some comments, most part LGTM.
I'm not familiar with MacOS apis, it's better to involve more maintainers to do double check.
src/passthrough/file_handle.rs
Outdated
| #[cfg(target_os = "macos")] | ||
| use nix::unistd::getuid; | ||
| use std::ffi::CString; | ||
| #[cfg(target_os = "macos")] |
There was a problem hiding this comment.
Modification to this files seems unnecessary.
There was a problem hiding this comment.
getuid and Read was never used even on macos platform, so I think you can remove these two lines safely:
use nix::unistd::getuid;
use std::io::Read;
c0997d6 to
198d548
Compare
Signed-off-by: akitaSummer <akitasummer@outlook.com>
akitaSummer
force-pushed
the
macos_passthrough
branch
from
198d548 to
6e88bd8
Compare
src/passthrough/file_handle.rs
Outdated
| #[cfg(target_os = "macos")] | ||
| use nix::unistd::getuid; | ||
| use std::ffi::CString; | ||
| #[cfg(target_os = "macos")] |
There was a problem hiding this comment.
getuid and Read was never used even on macos platform, so I think you can remove these two lines safely:
use nix::unistd::getuid;
use std::io::Read;
| @@ -0,0 +1,40 @@ | |||
| use std::{ | |||
There was a problem hiding this comment.
Missing lisence header.
| @@ -0,0 +1,137 @@ | |||
| use std::{ | |||
There was a problem hiding this comment.
Missing lisence header
| @@ -0,0 +1,120 @@ | |||
| use std::{ | |||
There was a problem hiding this comment.
Missing lisence header.
akitaSummer
force-pushed
the
macos_passthrough
branch
2 times, most recently
from
8aba2cd to
e4980d0
Compare
Signed-off-by: akitaSummer <akitasummer@outlook.com>
akitaSummer
force-pushed
the
macos_passthrough
branch
from
e4980d0 to
85fe445
Compare
Signed-off-by: akitaSummer <akitasummer@outlook.com>
3 participants
No description provided.