Conversation
|
🤖 Hey ! The security scan report for the current pull request is available here. |
2 similar comments
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
2 similar comments
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
| externUid: user.externUid, | ||
| provider: user.provider, | ||
| admin: user.admin, | ||
| auditor: user.auditor, |
There was a problem hiding this comment.
suggestion: Ptet faire un type dédié "UserDefinition" ? On le répète un peu trop, partout, là.
| value: true, | ||
| }, | ||
| }) | ||
| return result?.value ?? null |
There was a problem hiding this comment.
question: on throw pas, là ?
There was a problem hiding this comment.
Non, c'est tout à fait volontaire. Une valeur manquante signifie simplement que le flag n'a jamais été modifié côté UI (aka rien de spécial à faire) et c'est tout à fait acceptable.
|
|
||
| await Promise.all(project.members.map(async ({ user }) => { | ||
| const gitlabUser = await this.gitlab.upsertUser(user) | ||
| const isAdmin = adminRoleId ? user.adminRoleIds?.includes(adminRoleId) : undefined |
There was a problem hiding this comment.
suggestion: Un booléen ne devrait pas être autre chose que true ou false. Je sais que undefined est falsy, mais c'est inconfortable d'avoir un isXXXX qui contient des trucs inattendus.
There was a problem hiding this comment.
On l'avais deja vus dans l'ancien server. Le nommage est peut-etre pas correct.
undefine -> garder l'etat actuel
false -> deactiver
true -> activer
Comme l'update se fait sur un role a la fois cote console, on fait de l'update "partiel" de l'etat GitLab.
|
🤖 Hey ! The security scan report for the current pull request is available here. |
4 similar comments
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
|
0 New Issues
0 Fixed Issues
0 Accepted Issues2 participants
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr
Stack created with Sapling. Best reviewed with ReviewStack.