Skip to content

Verify default_password hash on launch #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025

Conversation

viktorerlingsson
Copy link
Member

WHAT is this pull request doing?

Verifies default_password hash on launch and provides a more useful error message if not valid.

Related to #1073

HOW can this pull request be tested?

Run LavinMQ with a bad password hash lavinmq --default_password=not-a-hash should exit early with an error message.

@viktorerlingsson viktorerlingsson requested a review from a team as a code owner April 28, 2025 13:58
@carlhoerberg
Copy link
Member

Should the argument be --default-password-hash= to not confuse ppl?

@viktorerlingsson viktorerlingsson force-pushed the verify_default_password_hash branch from 9bd90c8 to 9d2b7fd Compare May 7, 2025 09:51
@viktorerlingsson
Copy link
Member Author

Should the argument be --default-password-hash= to not confuse ppl?

Yeah, that's probably better!
Added default-password-hash and marked default-password as deprecated.

Copy link
Member

@kickster97 kickster97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@viktorerlingsson viktorerlingsson merged commit aa86c11 into main May 22, 2025
15 of 17 checks passed
@viktorerlingsson viktorerlingsson deleted the verify_default_password_hash branch May 22, 2025 12:58
kickster97 pushed a commit that referenced this pull request Jun 5, 2025
Verifies default_password_hash on launch and provides a more useful error message if not valid. Deprecates default_password in favor of default_password_hash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants