Do not delete message before delivering packet #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kickster97
changed the title
kickster97
force-pushed
the
deliver_packet_before_delete
branch
from
c89633e to
81fbdbb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
carlhoerberg
requested changes
May 6, 2025
Co-authored-by: Carl Hörberg <carl@84codes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
The build_packet method constructs an
MQTT::Publishpacket using the message data stored inenv.message.If the message has already been deleted (via
delete_message(sp)), theenv.messagereference becomes invalid, leading to a segmentation fault when accessed.This PR also fixes a bug where the
@consumers.empty?never got triggered because thedeliver_loopdidn't yield in time for theread_loopto take over and set theclient=nil, so thedeliver_loopwould continue to loop errors.Now we set
client=nilwhen thedeliver_loopexperiences an error, so theconsumers.empty?channel triggers and the loop waits for a new client connection.HOW can this pull request be tested?
run
lavinmqperf mqtt throughputvia themqtt-perfbranch and make sure there are no segment faults.