Skip to content

Exchanges must support binding arguments #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 26, 2025

Conversation

spuun
Copy link
Member

@spuun spuun commented May 5, 2025

WHAT is this pull request doing?

All exchanges must store binding arguments.

HOW can this pull request be tested?

Specs should cover it

@spuun spuun force-pushed the exchanges-must-support-binding-arguments branch from 3b67953 to 0ef8f05 Compare May 6, 2025 05:51
@spuun spuun force-pushed the exchanges-must-support-binding-arguments branch from 0ef8f05 to b788be8 Compare May 19, 2025 11:53
@spuun spuun marked this pull request as ready for review May 20, 2025 06:51
@spuun spuun requested a review from a team as a code owner May 20, 2025 06:51
Copy link
Member

@carlhoerberg carlhoerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some of the Sets can be Arrays instead? Should be cheaper, but not dealbreaker for this PR.

@spuun spuun force-pushed the exchanges-must-support-binding-arguments branch from b788be8 to 178153f Compare May 26, 2025 06:08
@spuun spuun merged commit 4e1a6b9 into main May 26, 2025
15 of 17 checks passed
@spuun spuun deleted the exchanges-must-support-binding-arguments branch May 26, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants