use a BoolChannel for @is_leader with a timeout to make sure it is set
#1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erly set before raising error when node is trying to become leader
…ts properly set before raising error when node is trying to become leader
carlhoerberg
reviewed
Jun 4, 2025
carlhoerberg
reviewed
Jun 4, 2025
Co-authored-by: Carl Hörberg <carl@84codes.com>
Co-authored-by: Carl Hörberg <carl@84codes.com>
carlhoerberg
changed the title
@is_leader with a timeout to make sure it is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Use a
BoolChannelfor @is_leaderwith a timeout to make sure its set before checking its value when a node is trying to become leader.Fixes a bug where sometimes a node would raise an error
FATAL lmq.clustering.controller Another node in the cluster is advertising the same URIwhen trying to become leader, because of a timing issue where @is_leader had not been set before it needed to be used.HOW can this pull request be tested?
Manual