Refactor workers-builds-notifications-template with improved Slack formatting #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview link not generated: you must be on a branch, not on a fork. |
- Add @slack/types for proper Block Kit typing instead of custom types - Fix author extraction edge case when name starts with @ - Add getBuildStatus helper to eliminate duplicated status logic - Add pagination safeguard (MAX_LOG_PAGES) to prevent infinite loops - Fix landing page to accurately reflect event behavior - Reduce test suite from 62 to 15 focused tests - Export helper functions for testability
Split src/index.ts (576 lines) into focused modules: - src/index.ts (79 lines) - Main queue handler - src/types.ts (88 lines) - Type definitions - src/api.ts (125 lines) - Cloudflare API calls - src/helpers.ts (196 lines) - Utility functions - src/slack.ts (246 lines) - Slack formatting and sending This makes the codebase easier to navigate and understand.
deloreyj
force-pushed
the
yomna/cleanup-notifications-template
branch
from
5024e61 to
a034036
Compare
deloreyj
force-pushed
the
yomna/cleanup-notifications-template
branch
from
a034036 to
3fec2a9
Compare
Contributor
|
Contributor
|
Preview link not generated: you must be on a branch, not on a fork. |
Contributor
|
Preview link not generated: you must be on a branch, not on a fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--source workersBuilds.worker,--worker-nameflag)Changes
src/index.tstest/index.spec.tsREADME.md.dev.vars.examplepreview.png