refactor: extract template string code generation into entries/ modules#259
Open
yunus25jmi1 wants to merge 1 commit intocloudflare:mainfrom
Open
refactor: extract template string code generation into entries/ modules#259yunus25jmi1 wants to merge 1 commit intocloudflare:mainfrom
yunus25jmi1 wants to merge 1 commit intocloudflare:mainfrom
Conversation
commit: |
Contributor
Author
|
@southpolesteve @threepointone @elithrar Kindly review the changes. The workflow is completely green. All checks are passed with 12 successful checks & 3 skipped. |
Collaborator
|
/bigbonk review please |
Contributor
|
@southpolesteve Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
yunus25jmi1
force-pushed
the
refactor/extract-entry-templates
branch
2 times, most recently
from
13e1c39 to
c9aedba
Compare
Extract 5 entry template generators from index.ts and app-dev-server.ts into packages/vinext/src/entries/: - app-rsc-entry.ts: generateRscEntry() + AppRouterConfig interface - app-ssr-entry.ts: generateSsrEntry() - app-browser-entry.ts: generateBrowserEntry() - pages-server-entry.ts: generateServerEntry() (closure -> explicit params) - pages-client-entry.ts: generateClientEntry() (closure -> explicit params) app-dev-server.ts is now a thin re-export barrel (12 lines, was 3034). index.ts reduced by ~1238 lines (2507, was 3745). Snapshot tests added in tests/entry-templates.test.ts to guard against template drift during future refactors. Closes cloudflare#253
yunus25jmi1
force-pushed
the
refactor/extract-entry-templates
branch
from
c9aedba to
1d34026
Compare
Contributor
Author
|
@southpolesteve, @james-elicx review the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the 5 template string code generation functions from \index.ts\ and \�pp-dev-server.ts\ into dedicated modules under \packages/vinext/src/entries/.
Changes
New files (\packages/vinext/src/entries/)
Modified files
Pages Router closure conversion
\generateServerEntry\ and \generateClientEntry\ were closures inside \�inext()\ that captured \pagesDir,
extConfig, and \middlewarePath. Converted to explicit function parameters.
Tests
Verification
Closes #253