test: app router instrumentation with cloudflare plugin

[james-elicx]

runs certain tests against a vite dev instance with the cloudflare plugin

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/vinext@333

commit: 2f9ca82

[github-actions]

Example	Preview	Production	Original
app-router-cloudflare	preview	production
pages-router-cloudflare	preview	production
app-router-playground	preview	production	original
realworld-api-rest	preview	production
nextra-docs-template	preview	production
benchmarks	preview	production
hackernews	preview	production	original

[james-elicx]

/bigbonk review

[ask-bonk]

Clean, well-scoped PR. The new cloudflare-dev Playwright project correctly runs vite dev (not wrangler dev) against the app-router-cloudflare example, which exercises configureServer() with @cloudflare/vite-plugin loaded — a code path that wasn't covered by the existing cloudflare-workers project (which only tests the build+wrangler production path).

A few observations:

Looks good:

• The testMatch pattern mirrors the cloudflare-workers project structure: cloudflare-specific tests in a dedicated directory plus the shared instrumentation.spec.ts.
• Port 4178 avoids conflicts with all existing projects (4173-4177).
• The 30s timeout is appropriate for a dev server (no build step).
• CI matrix entry is correct.

Minor note (non-blocking):

• The tests/e2e/cloudflare-dev/ directory doesn't exist yet — the glob for **/cloudflare-dev/**/*.spec.ts will match nothing today, so the project currently only runs instrumentation.spec.ts. That's fine as a starting point; presumably cloudflare-dev-specific tests will be added in follow-up PRs.

LGTM — this adds meaningful coverage for the dev-mode Cloudflare path with minimal blast radius.

[ask-bonk]

Approved PR #333. Here's a summary of the review:

Verdict: Approved

This is a clean, well-scoped addition. The new cloudflare-dev Playwright project runs vite dev against the app-router-cloudflare example, exercising configureServer() with @cloudflare/vite-plugin loaded — a code path that wasn't covered by the existing cloudflare-workers project (which only tests the build + wrangler production path).

The setup is correct: port 4178 avoids conflicts, the 30s timeout is appropriate for a dev server (no build step), and the CI matrix entry is properly added. The testMatch pattern mirrors the existing cloudflare-workers approach — a dedicated directory for future cloudflare-dev-specific tests plus the shared instrumentation.spec.ts.

One minor note: tests/e2e/cloudflare-dev/ doesn't exist yet, so only instrumentation.spec.ts runs today. That's fine as a starting point for follow-up work.

github run