[wrangler] fix: improve R2 CORS validation and error messaging#12456
Open
venkatnikhilm wants to merge 4 commits intocloudflare:mainfrom
Open
[wrangler] fix: improve R2 CORS validation and error messaging#12456venkatnikhilm wants to merge 4 commits intocloudflare:mainfrom
venkatnikhilm wants to merge 4 commits intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: ccdf0cc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #8486 by adding local validation to the r2 bucket cors set command.
Previously, users providing AWS S3-formatted CORS files (using CORSRules or PascalCase keys like AllowedOrigins) would receive a generic 10040 API error from the server. This PR intercepts these common formatting mistakes locally, providing a descriptive error message and a link to the correct Cloudflare R2 documentation.
Validation conducted:
Changes: