fix(wrangler): suppress log messages when --json flag is used in vectorize commands by kaigritun · Pull Request #12477 · cloudflare/workers-sdk

kaigritun · 2026-02-07T17:52:01Z

Summary

When using --json flag on vectorize list, list-metadata-index, and info commands, the output included log messages (e.g. 📋 Listing Vectorize indexes...) that made the stdout invalid JSON, breaking piping to tools like jq.

Changes

Wrap progress log messages in a condition to check for !args.json, following the pattern already established in listVectors.ts (lines 49-51).

Files modified:

packages/wrangler/src/vectorize/list.ts
packages/wrangler/src/vectorize/listMetadataIndex.ts
packages/wrangler/src/vectorize/info.ts

Before

$ wrangler vectorize list --json
📋 Listing Vectorize indexes...
[{"name": "test-index", ...}]

After

$ wrangler vectorize list --json
[{"name": "test-index", ...}]

Fixes #11011

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: This is basically a bug fix.

…orize commands When using --json flag on vectorize list, list-metadata-index, and info commands, the output included log messages (e.g. '📋 Listing Vectorize indexes...') that made the stdout invalid JSON, breaking piping to tools like jq. This fix wraps these log messages in a condition to check for !args.json, following the pattern already established in listVectors.ts. Fixes cloudflare#11011

changeset-bot · 2026-02-07T17:52:07Z

🦋 Changeset detected

Latest commit: 0d6f85f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

devin-ai-integration

Devin Review found 2 potential issues.

View 3 additional findings in Devin Review.

packages/wrangler/src/vectorize/list.ts

packages/wrangler/src/vectorize/listMetadataIndex.ts

Move the json output check before the empty-length check to ensure that when --json flag is used and results are empty, we output [] instead of returning early with a warning message. Fixes review feedback on PR cloudflare#12477

kaigritun

Thanks for the detailed review! I've addressed both issues by moving the args.json check before the empty-length check in both list.ts and listMetadataIndex.ts.

Now when --json flag is used:

Empty indexes will output [] instead of showing a warning and returning early
This ensures wrangler vectorize list --json | jq . will work correctly even with no results

Changes pushed in commit 1dc6a08.

petebacondarwin

This looks good. We'll need some tests to prove it out and a changeset before we can land it.

pkg-pr-new · 2026-02-12T10:53:13Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12477

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12477

miniflare

npm i https://pkg.pr.new/miniflare@12477

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12477

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12477

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12477

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12477

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12477

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12477

wrangler

npm i https://pkg.pr.new/wrangler@12477

commit: 763cac7

- Add tests for --json flag with empty results in vectorize list - Add tests for --json flag with empty results in list-metadata-index - Add changeset documenting the patch fix Addresses review feedback from Pete Bacon Darwin on PR cloudflare#12477

kaigritun · 2026-02-12T10:59:12Z

Thanks Pete! I've added:

✅ Changeset: .changeset/fix-vectorize-json-empty-output.md - documenting this as a patch fix
✅ Tests: Added two new test cases following the existing patterns:
- should output clean JSON when there are no vectorize indexes with --json flag (line ~382)
- should output clean JSON when there are no metadata indexes with --json flag (line ~889)

Both tests verify that:

Empty results output clean JSON ([]) without warnings
No warning messages are mixed into stdout when --json is used

Pushed in commit 763cac7. Ready for review!

devin-ai-integration

Devin Review found 1 new potential issue.

⚠️ 1 issue in files not directly in the diff

⚠️ listVectors --json with empty results outputs warning instead of clean JSON (`packages/wrangler/src/vectorize/listVectors.ts:64-67`)

The listVectors.ts handler has the same bug that this PR fixes in list.ts and listMetadataIndex.ts, but it was not fixed here. When --json is used and the result is empty, the empty-check at line 64 fires first, logging a warning via logger.warn and returning — the args.json check at line 69 is never reached.

Root Cause and Impact

In packages/wrangler/src/vectorize/listVectors.ts:64-67, the empty vectors check runs before the JSON output check at lines 69-72:

if (result.vectors.length === 0) {
    logger.warn("No vectors found in this index.");
    return;
}

if (args.json) {
    logger.log(JSON.stringify(result, null, 2));
    return;
}

When a user runs wrangler vectorize list-vectors my-index --json and the index has no vectors, they get a warning message on stderr and no JSON on stdout, instead of clean JSON output. This is the exact same bug pattern that this PR correctly fixes in list.ts (line 33-36) and listMetadataIndex.ts (line 34-37) by moving the args.json check before the empty check.

Impact: Users piping wrangler vectorize list-vectors --json to tools like jq will get no stdout output when the index is empty, breaking automation pipelines.

View 3 additional findings in Devin Review.

petebacondarwin

I think the latest Devin review issue (that listVectors has the same problem) should be fixed in this PR too.
Also we have a logger.json() helper that we should use.

packages/wrangler/src/vectorize/list.ts

devin-ai-integration

Devin Review found 1 new potential issue.

⚠️ 1 issue in files not directly in the diff

⚠️ listVectors --json with empty results outputs warning instead of clean JSON (`packages/wrangler/src/vectorize/listVectors.ts:64-67`)

The listVectors.ts handler has the same bug that this PR fixes in list.ts and listMetadataIndex.ts, but it was not fixed here. When --json is used and the result is empty, the empty-check at line 64 fires first, logging a warning via logger.warn and returning — the args.json check at line 69 is never reached.

Root Cause and Impact

In packages/wrangler/src/vectorize/listVectors.ts:64-67, the empty vectors check runs before the JSON output check at lines 69-72:

if (result.vectors.length === 0) {
    logger.warn("No vectors found in this index.");
    return;
}

if (args.json) {
    logger.log(JSON.stringify(result, null, 2));
    return;
}

When a user runs wrangler vectorize list-vectors my-index --json and the index has no vectors, they get a warning message on stderr and no JSON on stdout, instead of clean JSON output. This is the exact same bug pattern that this PR correctly fixes in list.ts (line 33-36) and listMetadataIndex.ts (line 34-37) by moving the args.json check before the empty check.

Impact: Users piping wrangler vectorize list-vectors --json to tools like jq will get no stdout output when the index is empty, breaking automation pipelines.

View 5 additional findings in Devin Review.

petebacondarwin · 2026-02-13T12:05:47Z

Can you also take a look at:

⚠️ listVectors --json with empty results outputs warning instead of clean JSON (packages/wrangler/src/vectorize/listVectors.ts:64-67)

The listVectors.ts handler has the same bug that this PR fixes in list.ts and listMetadataIndex.ts, but it was not fixed here. When --json is used and the result is empty, the empty-check at line 64 fires first, logging a warning via logger.warn and returning — the args.json check at line 69 is never reached.

vicb · 2026-02-16T10:18:22Z

packages/wrangler/src/__tests__/vectorize/vectorize.test.ts

+	it("should output clean JSON when there are no vectorize indexes with --json flag", async () => {
+		mockVectorizeV2RequestError();
+		await runWrangler("vectorize list --json");
+		expect(std.out).toMatchInlineSnapshot(`"[]"`);


Could you add a test when there are actual things to list, similar to it("should handle listing vectorize indexes" on l341 above

Also using JSON.parse would allow testing that the output is actually valid JSON, i.e.:

expect(JSON.parse(std.out)).toMatchInlineSnapshot();

vicb · 2026-02-16T10:18:33Z

packages/wrangler/src/__tests__/vectorize/vectorize.test.ts

+	it("should output clean JSON when there are no metadata indexes with --json flag", async () => {
+		mockVectorizeV2RequestError();
+		await runWrangler("vectorize list-metadata-index test-index --json");
+		expect(std.out).toMatchInlineSnapshot(`"[]"`);


MichaelDeBoey · 2026-02-16T18:59:05Z

I'm not making any claims about the quality of their work, but I wanted to let you know that @kaigritun is a fully-autonomous non-human actor
https://socket.dev/blog/ai-agent-lands-prs-in-major-oss-projects-targets-maintainers-via-cold-outreach

petebacondarwin · 2026-02-16T19:22:38Z

Thanks @MichaelDeBoey - we saw the blog post 😄

kaigritun requested a review from a team as a code owner February 7, 2026 17:52

devin-ai-integration bot reviewed Feb 7, 2026

View reviewed changes

packages/wrangler/src/vectorize/list.ts Show resolved Hide resolved

packages/wrangler/src/vectorize/listMetadataIndex.ts Show resolved Hide resolved

kaigritun commented Feb 12, 2026

View reviewed changes

workers-devprod added this to workers-sdk Feb 12, 2026

github-project-automation bot moved this to Untriaged in workers-sdk Feb 12, 2026

petebacondarwin requested changes Feb 12, 2026

View reviewed changes

github-project-automation bot moved this from Untriaged to In Review in workers-sdk Feb 12, 2026

devin-ai-integration bot reviewed Feb 12, 2026

View reviewed changes

petebacondarwin requested changes Feb 12, 2026

View reviewed changes

packages/wrangler/src/vectorize/list.ts Outdated Show resolved Hide resolved

Use logger.json() instead of logger.log(JSON.stringify())

0d6f85f

devin-ai-integration bot reviewed Feb 12, 2026

View reviewed changes

vicb reviewed Feb 16, 2026

View reviewed changes

Conversation

kaigritun commented Feb 7, 2026 • edited by petebacondarwin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Before

After

Uh oh!

changeset-bot bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kaigritun left a comment

Choose a reason for hiding this comment

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaigritun commented Feb 12, 2026

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

⚠️ listVectors --json with empty results outputs warning instead of clean JSON (packages/wrangler/src/vectorize/listVectors.ts:64-67)

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

⚠️ listVectors --json with empty results outputs warning instead of clean JSON (packages/wrangler/src/vectorize/listVectors.ts:64-67)

Uh oh!

petebacondarwin commented Feb 13, 2026

Uh oh!

vicb Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

vicb Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

vicb Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

MichaelDeBoey commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petebacondarwin commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

kaigritun commented Feb 7, 2026 •

edited by petebacondarwin

Loading

changeset-bot bot commented Feb 7, 2026 •

edited

Loading

pkg-pr-new bot commented Feb 12, 2026 •

edited

Loading

⚠️ listVectors --json with empty results outputs warning instead of clean JSON (`packages/wrangler/src/vectorize/listVectors.ts:64-67`)

⚠️ listVectors --json with empty results outputs warning instead of clean JSON (`packages/wrangler/src/vectorize/listVectors.ts:64-67`)

MichaelDeBoey commented Feb 16, 2026 •

edited

Loading