[miniflare] Fix Buffer type not accepted for D1 blob bindings#12514
Open
[miniflare] Fix Buffer type not accepted for D1 blob bindings#12514
Conversation
Buffer extends Uint8Array but isn't available in all runtimes. The ArrayBufferView reducer now normalises subclass constructor names to the nearest allowed parent, fixing D1 blob binding via getPlatformProxy(). Fixes #5771
Contributor
|
Claude finished @ascorbic's task —— View job Changeset Review✅ All changesets look good The changeset
The changeset clearly explains:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
🦋 Changeset detectedLatest commit: fab4e2d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5771.
The
ArrayBufferViewdevalue reducer serialises typed arrays by constructor name. Node.jsBufferextendsUint8Array, soArrayBuffer.isView()matches it and serialises["Buffer", ...]. On the workerd side, the reviver fails because:globalThis.Buffermay not exist in workerdBufferisn't inALLOWED_ARRAY_BUFFER_VIEW_CONSTRUCTORSThe fix normalises subclass constructor names to the nearest standard typed array parent in the reducer (not the reviver). This matches structured clone behaviour —
Bufferis serialised asUint8Array, which is what it extends.This affects anyone passing a
Bufferas a D1 bind parameter viagetPlatformProxy()or the Miniflare API.