Skip to content

fix: Correct public IP prefixes reference in NATGatewaysManager and r… #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Correct public IP prefixes reference in NATGatewaysManager and r… #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1130fb
fix: Correct public IP prefixes reference in NATGatewaysManager and r…
long-pham-ts Jun 9, 2025
a8d28eb
fix: Convert nested dict field notifications
long-pham-ts Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugin/manager/nat_gateways/instance_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def create_cloud_service(self, options, secret_data, schema):
nat_gateway_dict.update(
{
"public_ip_prefixes_count": len(
nat_gateway_dict["public_ip_addresses"]
nat_gateway_dict["public_ip_prefixes"]
)
}
)
Expand Down
4 changes: 3 additions & 1 deletion src/plugin/manager/vm_scale_sets/scale_set_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,8 @@ def create_cloud_service(self, options, secret_data, schema):
}
)

vm_scale_set_dict.pop("autoscale_settings")

self.set_region_code(vm_scale_set_dict["location"])

cloud_services.append(
Expand Down Expand Up @@ -376,7 +378,7 @@ def list_virtual_machine_scale_set_power_state(self, autoscale_obj_list):
), # profiles_list
"enabled": autoscale_setting.enabled,
"name": autoscale_setting.name,
"notifications": autoscale_setting.notifications,
"notifications": [self.convert_nested_dictionary(notification) for notification in autoscale_setting.notifications],
"target_resource_uri": autoscale_setting.target_resource_uri,
"tags": autoscale_setting.tags,
}
Expand Down
Loading