Skip to content

Add storage_cli_optional_flags to blobstore benchmarks #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kathap merged 2 commits into from
Jan 27, 2026
Merged

Add storage_cli_optional_flags to blobstore benchmarks #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13e06ce
Add storage_cli_optional_flags to blobstore benchmarks
kathap Jan 26, 2026
67d7d61
Use empty string as fallback if storage_cli_optional_flags is not set…
kathap Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions jobs/blobstore_benchmark/spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,5 @@ properties:
cc.stdout_logging_enabled:
default: false
description: "Enable logging to stdout"
cc.storage_cli_optional_flags:
description: "Storage Cli extra flags string"
4 changes: 4 additions & 0 deletions jobs/blobstore_benchmark/templates/cloud_controller_ng.yml.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@

cc_cfg = deep_merge_overwrite(cc_cfg, overrides)

if cc_cfg.key?("storage_cli_optional_flags")
cc_cfg["storage_cli_optional_flags"] = cc_cfg["storage_cli_optional_flags"].to_s
end

%w[resource_pool buildpacks packages droplets].each do |k|
section = cc_cfg[k]
next unless section.is_a?(Hash)
Expand Down