Add executing with nginx buildpack #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Docker integration tests by explicitly specifying nginx buildpack
Problem
When running integration tests on Docker platform, buildpack auto-detection was incorrectly selecting the PHP buildpack instead of the nginx buildpack. This caused tests to fail with errors like:
Expected the staging logs to contain "Installing nginx [\d\.]+" but got "Installing PHP 8.1.32" insteadThe issue occurred because the test fixtures didn't explicitly specify which buildpack to use, so Docker's auto-detection logic chose PHP based on the directory structure.
Solution
Added explicit buildpack specification using
.WithBuildpacks("nginx_buildpack")to all integration test