e2e-tests: wait for failed node in failover test #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the failover test only ran the "pre-start", and triggered the "start" phase of the bosh lifecycle but monit jobs could still be coming online. Now, the failover test runs "bosh cloud-check" with the "--resolution=recreate_vm" option to wait for the full bosh lifecycle, including the post-start job to be successful. In our test environments, it was observed that "bosh cloud-check --resolution=recreate_vm" could sometimes flag mutliple vms with "unresponsive agent" and during the repair phase observe the agent was _actually_ responsive causing bosh cloud-check to fail even though nothing was wrong. To avoid this problem, bosh cloud-check is run once to resolve the missing vm issue but any errors are ignored. A second bosh cloud-check --report is run a second time to validate there are no remaining deployment issues. [TNZ-67462](https://vmw-jira.broadcom.net/browse/TNZ-67462) Authored-by: Andrew Garner <andrew.garner@broadcom.com>
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Inbox
to Done
in Foundational Infrastructure Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the failover test only ran the "pre-start", and triggered the "start" phase of the bosh lifecycle but monit jobs could still be coming online.
Now, the failover test runs "bosh cloud-check" with the "--resolution=recreate_vm" option to wait for the full bosh lifecycle, including the post-start job to be successful.
In our test environments, it was observed that "bosh cloud-check --resolution=recreate_vm" could sometimes flag mutliple vms with "unresponsive agent" and during the repair phase observe the agent was actually responsive causing bosh cloud-check to fail even though nothing was wrong. To avoid this problem, bosh cloud-check is run once to resolve the missing vm issue but any errors are ignored. A second bosh cloud-check --report is run a second time to validate there are no remaining deployment issues.
TNZ-67462