Add ResourceRequirement. #82
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0832adafa8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cwl/sar_coherence.cwl
Outdated
| - entryname: "arguments.json" | ||
| entry: $(inputs) | ||
| ResourceRequirement: | ||
| ramMin: 4096 |
There was a problem hiding this comment.
ramMin and ramMax are preferebly set the same because ramMax won't be taken into consideration when scheduling workload so if requirements grow to ramMax you might end up OOM on the underlying hardware and then your job fails. So having different values for min and max for memory requirements reduces the reliability.
The same does not uphold for CPU sharing. For CPU the min is important to have a certain baseline performance and the max is useful to avoid taking too many resources but if you have a high max but not as many CPU us available your process won't die it will just be slower. The default CPU is 1 so you should at least increase cpuMin otherwise you will have poor performance and probably best to set cpuMax to some high value like 7.
There was a problem hiding this comment.
Is it ok to avoid coresMax instead of giving it a high value?
|
Running sar_coherence with 3 dates took 6.5Gb ram at peak: |
|
Ran 10 CWL jobs at the same time with this settings, and none crashed |
…on main branch first.
https://github.com/eu-cdse/openeo-cdse-infra/issues/883