chore: improve Makefile #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the shell used for `sh` is `dash`, which is common on Debian and its derivatives, the output of the Makefile is incorrect. This patch resolves the issue by using `bash` as the shell when it's available. Additionally, I refactored the `push` target to reuse the code that executes the push command for a specific directory. Lastly, the default action when you run `make` without any arguments is now to build all the extensions. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
NiccoloFei
approved these changes
Nov 26, 2025
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
force-pushed
the
dev/mnencia-review
branch
from
bf0dd4f to
68c01ce
Compare
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
force-pushed
the
dev/mnencia-review
branch
from
4af1f15 to
0f94425
Compare
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the shell used for
shisdash, which is common on Debian and its derivatives, the output of the Makefile is incorrect. This patch resolves the issue by usingbashas the shell when it's available.Additionally, I refactored the
pushtarget to reuse the code that executes the push command for a specific directory.Lastly, the default action when you run
makewithout any arguments is now to build all the extensions.