fix: compare body.Cap() with maxKeepBodySize instead of body.Len()#1294
Merged
fix: compare body.Cap() with maxKeepBodySize instead of body.Len()#1294
body.Cap() with maxKeepBodySize instead of body.Len()#1294Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1294 +/- ##
========================================
Coverage 72.38% 72.39%
========================================
Files 139 139
Lines 16235 16237 +2
========================================
+ Hits 11752 11754 +2
Misses 3888 3888
Partials 595 595 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
body.Cap() with maxKeepBodySize instead of body.Len()
FGYFFFF
reviewed
Mar 13, 2025
f824e5d to
701411e
Compare
YangruiEmma
previously approved these changes
Mar 25, 2025
d39f4b6 to
62118c1
Compare
62118c1 to
98ac70f
Compare
xiaost
approved these changes
Mar 25, 2025
Marina-Sakai
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: hertz use http-body-slice's length to compare with
MaxKeepBodySizeto decide if keep it in request/response or put intorequestBodyPoolonResetBody().However, a big request body (
.Len()>MaxKeepBodySize) which was firstly put intorequestBodyPoolis still likely to be used in subsequent request, even if the actually request data is small..therefore, once the subsequent request finish and back to
ResetBody()logic, although its body's Cap is much larger than Len, it will still be kept in request/repsponse, which may introduce memory leak.zh(optional): 将
MaxKeepBody的判定条件由Len()改成Cap()(Optional) Which issue(s) this PR fixes:
(Optional) The PR that updates user documentation: