Conversation
#### What type of PR is this? chore <!-- Add one of the following kinds: build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs) docs: Documentation only changes feat: A new feature optimize: A new optimization fix: A bug fix perf: A code change that improves performance refactor: A code change that neither fixes a bug nor adds a feature style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc) test: Adding missing tests or correcting existing tests chore: Changes to the build process or auxiliary tools and libraries such as documentation generation --> #### Check the PR title. <!-- The description of the title will be attached in Release Notes, so please describe it from user-oriented, what this PR does / why we need it. Please check your PR title with the below requirements: --> - [ ] This PR title match the format: \<type\>(optional scope): \<description\> - [ ] The description of this PR title is user-oriented and clear enough for others to understand. - [ ] Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. [User docs repo](https://github.com/cloudwego/cloudwego.github.io) #### (Optional) Translate the PR title into Chinese. #### (Optional) More detailed description for this PR(en: English/zh: Chinese). <!-- Provide more detailed info for review(e.g., it's recommended to provide perf data if this is a perf type PR). --> en: zh(optional): #### (Optional) Which issue(s) this PR fixes: <!-- Automatically closes linked issue when PR is merged. Eg: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> #### (Optional) The PR that updates user documentation: <!-- If the current PR requires user awareness at the usage level, please submit a PR to update user docs. [User docs repo](https://github.com/cloudwego/cloudwego.github.io) -->
also fixed accept error handling for network/standard
#### What type of PR is this? fix <!-- Add one of the following kinds: build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs) docs: Documentation only changes feat: A new feature optimize: A new optimization fix: A bug fix perf: A code change that improves performance refactor: A code change that neither fixes a bug nor adds a feature style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc) test: Adding missing tests or correcting existing tests chore: Changes to the build process or auxiliary tools and libraries such as documentation generation --> #### Check the PR title. <!-- The description of the title will be attached in Release Notes, so please describe it from user-oriented, what this PR does / why we need it. Please check your PR title with the below requirements: --> - [ ] This PR title match the format: \<type\>(optional scope): \<description\> - [ ] The description of this PR title is user-oriented and clear enough for others to understand. - [ ] Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. [User docs repo](https://github.com/cloudwego/cloudwego.github.io) #### (Optional) Translate the PR title into Chinese. fix(client): CloseIdleConnections 没有清理 TLS 连接 #### (Optional) More detailed description for this PR(en: English/zh: Chinese). <!-- Provide more detailed info for review(e.g., it's recommended to provide perf data if this is a perf type PR). --> en: zh(optional): #### (Optional) Which issue(s) this PR fixes: <!-- Automatically closes linked issue when PR is merged. Eg: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> #### (Optional) The PR that updates user documentation: <!-- If the current PR requires user awareness at the usage level, please submit a PR to update user docs. [User docs repo](https://github.com/cloudwego/cloudwego.github.io) -->
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1475 +/- ##
===========================================
+ Coverage 74.20% 86.38% +12.17%
===========================================
Files 147 149 +2
Lines 17006 14429 -2577
===========================================
- Hits 12620 12464 -156
+ Misses 3792 1427 -2365
+ Partials 594 538 -56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.