Conversation
There was a problem hiding this comment.
Pull request overview
Adds Windows coverage to the CI pipeline by introducing a dedicated stable Rust job on windows-latest, intended to catch Windows-specific compile/test regressions while leaving existing Linux/ARM jobs unchanged.
Changes:
- Add
test-stable-windowsjob to run stable toolchain tests onwindows-latest. - Run the existing
./scripts/test.shtest script from the new Windows job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/ci.yml
Outdated
| - name: Run tests | ||
| shell: bash | ||
| run: ./scripts/test.sh |
There was a problem hiding this comment.
On Windows runners, invoking the script as ./scripts/test.sh can fail if the executable bit isn't preserved by checkout (common on Windows), resulting in Permission denied. Prefer running it via the interpreter (e.g., bash ./scripts/test.sh) so the job doesn't rely on POSIX exec permissions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 69.97% 69.97%
=======================================
Files 42 42
Lines 9917 9917
=======================================
Hits 6939 6939
Misses 2978 2978 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add a dedicated windows-latest CI job that runs the existing test script to catch Windows-specific build regressions early.
Call the test script via the interpreter on Windows to avoid executable-bit related failures on checkout.
b69b9b4 to
7314b69
Compare
Summary
test-stable-windowsjob in.github/workflows/ci.yml../scripts/test.shonwindows-latestto catch Windows-specific compile/test regressions.Test plan
cargo checklocally.