Skip to content

ci: add stable Windows CI job#216

Merged
liuq19 merged 2 commits intomainfrom
fix/windows-ci
Feb 26, 2026
Merged

ci: add stable Windows CI job#216
liuq19 merged 2 commits intomainfrom
fix/windows-ci

Conversation

@liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Feb 25, 2026

Summary

  • Add a dedicated test-stable-windows job in .github/workflows/ci.yml.
  • Run the existing ./scripts/test.sh on windows-latest to catch Windows-specific compile/test regressions.
  • Keep existing Linux/ARM jobs unchanged.

Test plan

  • Run cargo check locally.
  • Verify the new Windows job passes in GitHub Actions.

Copilot AI review requested due to automatic review settings February 25, 2026 14:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Windows coverage to the CI pipeline by introducing a dedicated stable Rust job on windows-latest, intended to catch Windows-specific compile/test regressions while leaving existing Linux/ARM jobs unchanged.

Changes:

  • Add test-stable-windows job to run stable toolchain tests on windows-latest.
  • Run the existing ./scripts/test.sh test script from the new Windows job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +16 to +18
- name: Run tests
shell: bash
run: ./scripts/test.sh
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows runners, invoking the script as ./scripts/test.sh can fail if the executable bit isn't preserved by checkout (common on Windows), resulting in Permission denied. Prefer running it via the interpreter (e.g., bash ./scripts/test.sh) so the job doesn't rely on POSIX exec permissions.

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.97%. Comparing base (adb31a1) to head (7314b69).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   69.97%   69.97%           
=======================================
  Files          42       42           
  Lines        9917     9917           
=======================================
  Hits         6939     6939           
  Misses       2978     2978           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add a dedicated windows-latest CI job that runs the existing test script to catch Windows-specific build regressions early.
Call the test script via the interpreter on Windows to avoid executable-bit related failures on checkout.
@liuq19 liuq19 merged commit 3336cbc into main Feb 26, 2026
14 of 20 checks passed
@liuq19 liuq19 deleted the fix/windows-ci branch February 26, 2026 03:29
timeout-minutes: 45
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'CI' step
Uses Step
uses 'dtolnay/rust-toolchain' with ref 'stable', not a pinned commit hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants