Skip to content

fix: remove unnecessary target_feature = "pclmulqdq"#218

Open
utkarshgupta137 wants to merge 1 commit intocloudwego:mainfrom
utkarshgupta137:fix/simd-cfg
Open

fix: remove unnecessary target_feature = "pclmulqdq"#218
utkarshgupta137 wants to merge 1 commit intocloudwego:mainfrom
utkarshgupta137:fix/simd-cfg

Conversation

@utkarshgupta137
Copy link

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: The target_feature in question enables clmulepi, which is not used in this module, so it should be removed to improve performance on more targets.
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.97%. Comparing base (3336cbc) to head (01de793).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   69.97%   69.97%           
=======================================
  Files          42       42           
  Lines        9917     9917           
=======================================
  Hits         6939     6939           
  Misses       2978     2978           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@utkarshgupta137
Copy link
Author

The failures are formatting errors unrelated to this change @liuq19.

@hsqStephenZhang
Copy link
Collaborator

@utkarshgupta137
Copy link
Author

https://github.com/simd-lite/simd-json/blob/685257ad7073e02dfec836f91fe0eb077b434435/.github/workflows/tests.yml#L20 maybe we should make CI happy with cpu flags disabled

The current failures with this PR are related to formatting & clippy which are unrelated to this change.

@liuq19
Copy link
Collaborator

liuq19 commented Mar 13, 2026

@codex

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants