fix: remove unnecessary target_feature = "pclmulqdq"#218
fix: remove unnecessary target_feature = "pclmulqdq"#218utkarshgupta137 wants to merge 1 commit intocloudwego:mainfrom
target_feature = "pclmulqdq"#218Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
=======================================
Coverage 69.97% 69.97%
=======================================
Files 42 42
Lines 9917 9917
=======================================
Hits 6939 6939
Misses 2978 2978 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The failures are formatting errors unrelated to this change @liuq19. |
|
https://github.com/simd-lite/simd-json/blob/685257ad7073e02dfec836f91fe0eb077b434435/.github/workflows/tests.yml#L20 maybe we should make CI happy with cpu flags disabled |
The current failures with this PR are related to formatting & clippy which are unrelated to this change. |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: The target_feature in question enables
clmulepi, which is not used in this module, so it should be removed to improve performance on more targets.zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: