Skip to content

Update test suite to ensure 100% code coverage across Promise v3/v2/v1 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Update test suite to ensure 100% code coverage across Promise v3/v2/v1 #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"clue/json-stream": "^0.1",
"react/event-loop": "^1.2",
"react/http": "^1.8",
"react/promise": "^3 || ^2.0 || ^1.1",
"react/promise": "^3.1 || ^2.11 || ^1.3",
"react/promise-stream": "^1.6",
"react/socket": "^1.12",
"react/stream": "^1.2",
Expand Down
6 changes: 2 additions & 4 deletions tests/Io/StreamingParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
use Clue\React\Docker\Io\StreamingParser;
use Clue\Tests\React\Docker\TestCase;
use React\Promise;
use React\Promise\CancellablePromiseInterface;
use React\Promise\Deferred;
use React\Stream\ThroughStream;

Expand Down Expand Up @@ -119,11 +118,10 @@ public function testDeferredCancelingPromiseWillCloseStream()
$stream->expects($this->once())->method('isReadable')->willReturn(true);

$promise = $this->parser->deferredStream($stream);
if (!($promise instanceof CancellablePromiseInterface)) {
$this->markTestSkipped('Requires Promise v2 API and has no effect on v1 API');
}

$stream->expects($this->once())->method('close');

assert(method_exists($promise, 'cancel'));
$promise->cancel();
}

Expand Down