Skip to content

Update close handler to avoid unhandled promise rejections #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2023
Merged

Update close handler to avoid unhandled promise rejections #144

merged 1 commit into from
Jul 10, 2023

Conversation

clue
Copy link
Owner

@clue clue commented Jul 10, 2023

Builds on top of reactphp/promise#248 and #134

@clue clue added this to the v3.0.0 milestone Jul 10, 2023
@clue clue requested a review from SimonFrings July 10, 2023 07:18
@SimonFrings SimonFrings merged commit a39fa70 into clue:3.x Jul 10, 2023
@SimonFrings SimonFrings deleted the unhandled-rejections branch July 10, 2023 08:47
@clue clue mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@SimonFrings SimonFrings SimonFrings approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug new feature
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@clue @SimonFrings