Skip to content

Run tests on PHP 8.4 and update test environment #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Run tests on PHP 8.4 and update test environment #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ jobs:
strategy:
matrix:
os:
- ubuntu-22.04
- ubuntu-24.04
- windows-2022
php:
- 8.4
- 8.3
- 8.2
- 8.1
- 8.0
Expand All @@ -36,8 +38,8 @@ jobs:
extensions: sqlite3
coverage: xdebug
ini-file: development
# disable JIT on PHP 8.2 with Xdebug: JIT is incompatible with third party extensions that override zend_execute_ex(). JIT disabled.
ini-values: ${{ matrix.php == 8.2 && 'opcache.jit_buffer_size=0' || '' }}
# disable JIT on PHP 8.2+ with Xdebug: JIT is incompatible with third party extensions that override zend_execute_ex(). JIT disabled.
ini-values: ${{ matrix.php >= 8.2 && 'opcache.jit_buffer_size=0' || '' }}
- run: composer install
- run: vendor/bin/phpunit --coverage-text --coverage-clover=clover.xml
if: ${{ matrix.php >= 7.3 }}
Expand Down
2 changes: 1 addition & 1 deletion tests/FunctionalFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function testOpenReturnsPromiseWhichFulfillsWithConnectionForMemoryPathAn
public function testOpenReturnsPromiseWhichRejectsWithExceptionWhenPathIsInvalid()
{
$factory = new Factory();
$promise = $factory->open('/dev/foobar');
$promise = $factory->open('/dev/foo/bar');

$promise->then(function (DatabaseInterface $db) {
echo 'open.';
Expand Down
2 changes: 1 addition & 1 deletion tests/Io/BlockingDatabaseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public function testCtorThrowsForInvalidPath()
// legacy PHPUnit
$this->setExpectedException('Exception');
}
new BlockingDatabase('/dev/foobar');
new BlockingDatabase('/dev/foo/bar');
}

public function testExecReturnsRejectedPromiseForInvalidQuery()
Expand Down