Skip to content

Conversation

@cgsavard
Copy link

@cgsavard cgsavard commented Dec 6, 2024

The changes in the wiring maps no longer allow duplicate triplet seeds to be created in the TrackletProcessorDisplaced. These changes were presented to the L1Tk group here and the same changes are going into the forked cmssw branch (PR here) until this PR goes through. A minor change for the prompt tracking is also made to no longer create duplicates of seed 6.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

A new Pull Request was created by @cgsavard for branch master.

@aandvalenzuela, @aloeliger, @cmsbuild, @epalencia, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

cms-bot internal usage

@cgsavard cgsavard marked this pull request as draft December 6, 2024 21:32
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2024

Pull request #7 was updated.

@cgsavard cgsavard marked this pull request as ready for review December 7, 2024 00:30
@smuzaffar
Copy link
Contributor

@cms-sw/l1-l2 is this still needed?
@cgsavard , is there any CMSSW PR to test this change?

@aloeliger
Copy link

To be fully honest, I had forgotten this PR. I don't know if it is still needed. @cgsavard?

@cgsavard
Copy link
Author

Yes this is still needed, it was tested in this PR here.

@tomalin
Copy link

tomalin commented May 12, 2025

Hi, this PR seems to be paused for no apparent reason since months?

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17208e/46963/summary.html
COMMIT: 114434b
CMSSW: CMSSW_15_1_X_2025-06-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-TrackFindingTracklet/7/46963/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17208e/46963/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17208e/46963/git-merge-result

Comparison Summary

Summary:

@tomalin
Copy link

tomalin commented Jul 8, 2025

This PR has now taken 7 months to merge, despite not needing any corrections. I'd hoped it would go into CMSSW 15_1_0_pre4, but it's too late. Can we get it into pre5? Thanks.

@tomalin
Copy link

tomalin commented Nov 6, 2025

Can I ping this again? We've been waiting almost a year to get this merged, despite there being no review comments and it passing all checks.

@mandrenguyen
Copy link

Once @cms-sw/l1-l2 signs we can merge

@smuzaffar
Copy link
Contributor

+externals

good to go from external point of view

@smuzaffar
Copy link
Contributor

please test using full cmssw

lets refresh the tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17208e/49757/summary.html
COMMIT: 114434b
CMSSW: CMSSW_16_0_X_2025-12-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/7/49757/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17208e/49757/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17208e/49757/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 187 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4269233
  • DQMHistoTests: Total failures: 92
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4269121
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants