-
Notifications
You must be signed in to change notification settings - Fork 5
New wiring for TrackletProcessorDisplaced #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
A new Pull Request was created by @cgsavard for branch master. @aandvalenzuela, @aloeliger, @cmsbuild, @epalencia, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
Pull request #7 was updated. |
|
@cms-sw/l1-l2 is this still needed? |
|
To be fully honest, I had forgotten this PR. I don't know if it is still needed. @cgsavard? |
|
Yes this is still needed, it was tested in this PR here. |
|
Hi, this PR seems to be paused for no apparent reason since months? |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17208e/46963/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
This PR has now taken 7 months to merge, despite not needing any corrections. I'd hoped it would go into CMSSW 15_1_0_pre4, but it's too late. Can we get it into pre5? Thanks. |
|
Can I ping this again? We've been waiting almost a year to get this merged, despite there being no review comments and it passing all checks. |
|
Once @cms-sw/l1-l2 signs we can merge |
|
+externals good to go from external point of view |
|
please test using full cmssw lets refresh the tests |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17208e/49757/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
The changes in the wiring maps no longer allow duplicate triplet seeds to be created in the TrackletProcessorDisplaced. These changes were presented to the L1Tk group here and the same changes are going into the forked cmssw branch (PR here) until this PR goes through. A minor change for the prompt tracking is also made to no longer create duplicates of seed 6.