Skip to content

Conversation

@aehart
Copy link
Contributor

@aehart aehart commented Jul 10, 2025

This PR includes three changes:

  • removes files that are not only obsolete but, in most cases, incompatible with the current code in L1Trigger/TrackFindingTracklet
  • adds a JSON file that contains an equivalent description of the wiring contained in the DAT files; this easier-to-edit format will become the default description in the near future
  • updates the README to reflect the new repository contents

Just to be clear, none of the files that are removed or added by this PR are currently used in L1Trigger/TrackFindingTracklet by default.

@tomalin

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aehart for branch master.

@BenjaminRS, @akritkbehera, @cmsbuild, @iarspider, @quinnanm, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #8 was updated.

@aehart
Copy link
Contributor Author

aehart commented Jul 23, 2025

Just FYI, seedWiring.json, which is added to the repository in this PR, has been further refined to remove superfluous projections that are not allowed by the C++ code.

@tomalin
Copy link

tomalin commented Oct 8, 2025

Hi all, had two PRs to this repository pending for ages, for no apparent reason. Can someone please merge them?

@iarspider
Copy link

Is there a cmssw pr to test this PR with? Or is it a standalone pr?
Also, the L1 signature is missing.

@tomalin
Copy link

tomalin commented Nov 6, 2025

@iarspider This PR is just a clean up . It can be used with any recent CMSSW version, and result should be unaffected.

@smuzaffar
Copy link
Contributor

please test using full cmssw

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c211cd/49752/summary.html
COMMIT: 67dc0fe
CMSSW: CMSSW_16_0_X_2025-12-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c211cd/49752/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c211cd/49752/git-merge-result

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS

Failed RelVals

----- Begin Fatal Exception 02-Dec-2025 17:40:32 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/table_TED/table_TED_D1PHIA1_D2PHIA1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/external/el8_amd64_gcc13/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/34434.911_TTbar_14TeV+Run4D121_DD4hep


At:
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Mixins.py(399): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Mixins.py(534): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Config.py(1120): _insertManyInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Config.py(1331): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 02-Dec-2025 17:32:43 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/table_TED/table_TED_D1PHIA1_D2PHIA1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/external/el8_amd64_gcc13/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/34434.0_TTbar_14TeV+Run4D121


At:
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Mixins.py(399): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Mixins.py(534): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Config.py(1120): _insertManyInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Config.py(1331): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 02-Dec-2025 17:33:15 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT_VALIDATION.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/TrackFindingTracklet/data/table_TED/table_TED_D1PHIA1_D2PHIA1.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/external/el8_amd64_gcc13/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/34434.75_TTbar_14TeV+Run4D121_HLT75e33Timing


At:
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Mixins.py(399): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Mixins.py(534): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Config.py(1120): _insertManyInto
  /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/8/49752/CMSSW_16_0_X_2025-12-01-2300/src/FWCore/ParameterSet/python/Config.py(1331): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

@tomalin
Copy link

tomalin commented Dec 8, 2025

@aehart The reason this PR fails is that there are still references in the C++ code of L1Trigger/TrackFindingTracklet/ to TREFile and TEDFile. As far as I can tell, the code makes no use of these, so I'd suggest we make a PR to central CMSSW to delete them all (or comment them out if the intention is to use them to apply cuts to the displaced tracking at some point in future?).
N.B. In our L1 track development branch, the contents of our L1Trigger/TrackFindingTracklet/data/ directory correspond to your PR. I was therefore surprised that we had not observed the same crash there. The reason it does not happen is that the utility FileInPath first searches for any txt file it wants in your local area, and if it can't find them there, it then looks in the official CMSSW area. And as these txt files have not yet been deleted from cms-data, it was finding them there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants