-
Notifications
You must be signed in to change notification settings - Fork 5
Repository cleanup #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
A new Pull Request was created by @aehart for branch master. @BenjaminRS, @akritkbehera, @cmsbuild, @iarspider, @quinnanm, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
Pull request #8 was updated. |
|
Just FYI, seedWiring.json, which is added to the repository in this PR, has been further refined to remove superfluous projections that are not allowed by the C++ code. |
|
Hi all, had two PRs to this repository pending for ages, for no apparent reason. Can someone please merge them? |
|
Is there a cmssw pr to test this PR with? Or is it a standalone pr? |
|
@iarspider This PR is just a clean up . It can be used with any recent CMSSW version, and result should be unaffected. |
|
please test using full cmssw |
|
-1 Failed Tests: UnitTests RelVals The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Failed Unit TestsI found 1 errors in the following unit tests: ---> test testPhase2PixelNtuple had ERRORS Failed RelVals |
|
@aehart The reason this PR fails is that there are still references in the C++ code of L1Trigger/TrackFindingTracklet/ to TREFile and TEDFile. As far as I can tell, the code makes no use of these, so I'd suggest we make a PR to central CMSSW to delete them all (or comment them out if the intention is to use them to apply cuts to the displaced tracking at some point in future?). |
This PR includes three changes:
Just to be clear, none of the files that are removed or added by this PR are currently used in L1Trigger/TrackFindingTracklet by default.
@tomalin